Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

[master] issue 755 #782

Merged
merged 5 commits into from
Oct 22, 2014
Merged

[master] issue 755 #782

merged 5 commits into from
Oct 22, 2014

Conversation

nmccready
Copy link
Contributor

  • main issue is gMarkerManager needs to be cleaned up scope.on '$destroy' for marker and markers
  • promises / deffereds need to be reset on destroy for map, marker and window

@gitnik

nmccready
nmccready reviewed Oct 22, 2014
View reviewed changes
example/assets/scripts/controllers/issue-755-ng-router.js
@@ -0,0 +1,54 @@
angular.module("markerCoordsTest", ['ngRoute',"google-maps".ns()])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example to test issue #755 via ng-router tab view

@nmccready
Copy link
Contributor Author

merging this is more of a paper trail, if people become more active I will wait on merges (wait on comments)

nmccready added a commit that referenced this pull request Oct 22, 2014
@nmccready
Merge pull request #782 from nmccready/hotfix/nmccready/issue_755
ad5920b 
[master] issue 755
@nmccready nmccready merged commit ad5920b into angular-ui:master Oct 22, 2014
@nmccready
Copy link
Contributor Author

#755 resolved

@nmccready nmccready mentioned this pull request Oct 22, 2014
Closed
@nmccready nmccready deleted the hotfix/nmccready/issue_755 branch March 6, 2015 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nmccready