Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

Fixing mapControl directive when using full jQuery. #780

Merged
merged 1 commit into from
Oct 22, 2014
Merged

Fixing mapControl directive when using full jQuery. #780

merged 1 commit into from
Oct 22, 2014

Conversation

bensgroi
Copy link
Contributor

Replacing controlDiv.contents() with controlDiv.children() in Control.prototype.link. jqLite appears to have a bug in that its .append() method doesn't behave exactly like jQuery's, resulting in an error when using the jQuery and the mapControl directive and when there's leading whitespace in the ng-template script tag (which is probably always the case).

For example, this causes an error:

<script type="text/ng-template" id="control.tpl.html">
  <button>control</button>
</script>

but this does not:

<script type="text/ng-template" id="control.tpl.html"><button>control</button></script>

Replacing controlDiv.contents() with controlDiv.children() in Control.prototype.link. jqLite appears to have a bug in that its .append() method doesn't behave exactly like jQuery's, resulting in an error when using the jQuery and the mapControl directive and when there's leading whitespace in the ng-template script tag (which is probably always the case).
@nmccready
Copy link
Contributor

thanks

nmccready added a commit that referenced this pull request Oct 22, 2014
Fixing mapControl directive when using full jQuery.
@nmccready nmccready merged commit 107a7c4 into angular-ui:master Oct 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants