Feature/icon update without destroy #60
Conversation
directive is not angular apparently.
- on value change the google.marker's icon will be set - marker will be removed from the map and then readded in the same position.
|
I like this, but why setting map to null, and then to the current map instance and then re-reading the coordinates from the scope to change the icon ? |
|
Nevermind, saw your comment on the issue. |
…Marker basis, especially if you are only trying to allow one Window at a time.[C
|
Will this be merged soon? I have another update that builds on this.. I added a handle to closeclick on scope as well. This is important if you keep track of the state of the windows that are open if you only want one to be open. |
|
I could wait for your update. Btw you're on fire! |
|
Yeah I am using this library a lot. Anyway I can eventually be added as an admin. BTW I still do not understand where the specs are. Do they need to be added or is there a set that already exist? |
|
Ok I will merge my other feature into this pull so this should include the closeClick stuff. |
|
What do you mean by specs? like api reference for this library? There are none. |
|
Oh you mean test specs. There are none ;) |
|
Yeah we really need to add specs.. to make sure our code is testable. This should be marked as an issue for sure. |
|
Right. I'll open it. |
|
Ok I think closeClick is now in this pull |
…estroy Feature/icon update without destroy
|
Thanks for your contribution. This is starting to look llike something. |
|
lol I was about to do this. I was adding more comments... oh well. Thanks for the privs. |
|
BTW do you use git flow? |
|
git flow? |
|
http://jeffkreeftmeijer.com/2010/why-arent-you-using-git-flow/ Nicholas McCready Personal Email: [email protected] On Mon, Jul 15, 2013 at 10:45 PM, Nicolas Laplante <[email protected]
|
|
Nicholas McCready Personal Email: [email protected] On Mon, Jul 15, 2013 at 10:45 PM, Nicolas Laplante <[email protected]
|
ghost
assigned 
This pull encapsulates isIConVisibleOnClick changes and marker.icon. See the commits below to understand.
The marker fix is with regards to this issue: #59