This repository was archived by the owner on Nov 30, 2018. It is now read-only.
Fixed bounds, center and zoom handling #1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the requirement for bounds, center and zoom attributes on the ui-gmap-google-map directive. Now only the center or bounds attribute is required, and the zoom is optional (it defaults to 10). If only the bounds attribute is specified, the center lat/long is derived. Closes angular-ui#1360.
Just revisited this branch - these validation check are too zealous. They are preventing the map directive from loading when the bounds or center properties are not populated until the Google maps API is ready (eg. with the supplied maps example).
|
I'll try to look at this soon. Mainly want to pull it down and run existing examples. |
|
Sounds good, let me know if I can help out. Thank you for angular-google-maps, it's awesome. |
|
LGTM |
nmccready
added a commit
that referenced
this pull request
Mar 13, 2016
Fixed bounds, center and zoom handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the requirement for
bounds,centerandzoomattributes on theui-gmap-google-mapdirective. Now only acenterorboundsattribute is required, and thezoomattribute is optional (it defaults to 10). If only theboundsattribute is specified, thecenterlat/long is derived. Closes #1360.