[r1-dev] supporting labels on markers directive #139
Conversation
| @createMarker(model) | ||
| @doClick = doClick | ||
| @$log = directives.api.utils.Logger | ||
| constructor:(@index, @model, @parentScope, @gMap, $timeout, @defaults, @doClick, @gMarkerManager)-> |
There was a problem hiding this comment.
nice , I have been doing this myself lately as well with @ params in the constructor.
ghost
assigned
| @@ -1,6 +1,9 @@ | |||
| @ngGmapModule "directives.api.utils", -> | |||
| @GmapUtil = | |||
| getLabelPositionPoint:(anchor) -> | |||
| if anchor == undefined | |||
| return undefined | |||
|
|
|||
| anchor = /^([\d\.]+)\s([\d\.]+)$/.exec(anchor) | |||
There was a problem hiding this comment.
Please comment this regex's purpose.
There was a problem hiding this comment.
I didn't create it as it was already used by the marker-label directive but it's supposed to match two digits separated by space I think. The anchor param is represented by a point and we are using this format "d d".
|
So far looks good, I will run it later when I get the chance. |
|
I just fixed some major bugs on Window. I can try to merge this or you can. I will definitely review it this week. If it passes this week then it will make it in with the first release. |
|
LGTM, passes when ran locally ty @fwitzke . Sorry I took so long. |
[r1-dev] supporting labels on markers directive
No description provided.