[develop] ng-show within window not working

[ghost]

When I use ng-show within the window directive, my strong-tag won't show although the expression is true. I put the expression I'm using outside the ng-show and then it says "true", so the expression is indeed true.
This is only an issue on the development version, as it does work on the release version.

I created a plunker to show my problem.
http://plnkr.co/edit/A6eDExMqECldHAOLcVGP

[ghost]

I created a simplified version of the previous plunker.

http://plnkr.co/edit/ysjZukPCJ9yCo7MUhZCU?p=preview

[francisdb]

We are having the same problem. Does anybody have a hint on how this could be fixed or where the actual issue is? This is a regression as it works on master...

[nmccready]

I'll add it to 1.1.0 milestone.

[nmccready]

This probably happened due to the efforts of getting clicking to work inside a window. If ng-show is not working though the main controller it might need a sub-controller like infoWindowController (in the examples).

[nmccready]

Areas that changed and compile the template.

This is for the actual child (after) it has been interpolated by windows parent.
https://github.com/nlaplante/angular-google-maps/blob/develop/src/coffee/directives/api/utils/gmap-util.coffee#L44-L68

[nmccready]

Is this on both windows and window directive?

[francisdb]

We are using window

[nmccready]

Ok it is called from here, https://github.com/nlaplante/angular-google-maps/blob/develop/src/coffee/directives/api/window.coffee#L22

[nmccready]

Window is much easier to debug, however the fix needs to work for both.

[francisdb]

Hmm, I fear my angular skills are not adequate to understand everything you are explaining but thanks for looking into this issue.

[nmccready]

Ok I'll get to it when I can.

[nmccready]

@BenSwennen @francisdb I am pretty sure this is not a bug but a mis-understanding of how things work. I believe this is the same situation on how to get things to work with a button click within a window. Therefore you will need a second controller which is bound to each window and you will use it's scope function and properties. Please see the examples for inforWindowController. I will verify this.

[francisdb]

@nmccready So why this complexity of adding another controller, can't this "just work" as one would expect?

[nmccready]

I am not entirely sure yet but I know that the other way works. @nlaplante might have a better explanation as he originally got the clicking to work.

[nmccready]

I think I can maybe explain it a little better. You need to break the idea that window being created via the directive is alway attached to the main controller. Once it is created by google it is detached from the scope of any controller. Therefore we need to rebind it to another controller which injects itself into the real window. The {{m.whatever}} portion is only being used for compiling of the html which is handed off to the google options to create the html.

[nmccready]

I am editing the plunkr. Maybe a possible improvement of this can come at later time, but the work around should be sufficient for this release.

[francisdb]

Ok, thanks, that should at least get us going 👍

[nmccready]

Here you go http://plnkr.co/edit/h8g0NGkJQqi2I6KtKBsr?p=preview

[knapeto]

Hey all,

I have still problem with ng-show..

I have dynamic selected.

<ui-gmap-window coords="selected" show="selected.show" closeClick='selected.onMarkerClose()' ng-cloak>

    <div style="min-width: 230px;">

        <div ng-show="selected.atest">aaa</div>

        <div ng-show="selected.btest">bbb</div>

    </div>

</ui-gmap-window>

[abdellah-neo]

For people still experiencing this issue: you can use :
ng-show="{{boolean}}
It works just fine

[nmccready]

Thanks @abdellah-neo