Skip to content

fix(engine): remove extraneous slash from extended commit message for GitHub Actions #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EdricChan03
Copy link
Contributor

@EdricChan03 EdricChan03 commented Jan 7, 2020

Currently, in 0.6.2 of angular-cli-ghpages, the extended commit message for GitHub Actions has an extraneous slash in the URL. Fortunately, the extra slash does not break the URL.

This PR simply removes the extra slash in the URL.

Before:

<commit message>

Triggered by commit: https://github.com/EdricChan03/rss-reader//commit/d8b3b445e1963df9075b97d691609f9f19da9626

After:

<commit message>

Triggered by commit: https://github.com/EdricChan03/rss-reader/commit/d8b3b445e1963df9075b97d691609f9f19da9626

See EdricChan03/rss-reader-angular@14f9b02 for an example.

P.S. Could there be added tests for the extended commit messages to verify that they work?

@JohannesHoppe
Copy link
Member

I was too lazy for a test, shame on me! 😆

@JohannesHoppe JohannesHoppe merged commit 2b33d1c into angular-schule:master Jan 7, 2020
@EdricChan03 EdricChan03 deleted the fix/remove-extra-slash branch January 7, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants