Skip to content

feat: ng-add with Angular 14 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2022
Merged

feat: ng-add with Angular 14 #149

merged 6 commits into from
Jun 17, 2022

Conversation

fmalcher
Copy link
Member

@fmalcher fmalcher commented Jun 15, 2022 •
edited
Loading

see commit messages for further info!

TODO:

  • docs for the new --project option for ng-add
  • manual validation in Angular 14 project
  • manual validation in older project (for downwards compatibility)

⚠️ Please merge with rebase (no squash) so that the commit history will remain.

resolve #148

fmalcher added 2 commits June 15, 2022 22:39
@fmalcher
feat: support Angular 14 in devDeps and peerDeps
57963e0
@fmalcher
feat(ng-add): add public "project" config property
0a28c48 
Starting with NG14 there is no defaultProject setting in angular.json anymore.
With this setting, we can manually select the project that we want to add the deploy config to.
@fmalcher fmalcher requested a review from JohannesHoppe June 15, 2022 21:10
fmalcher added 2 commits June 16, 2022 09:10
@fmalcher
feat(ng-add): add logic for project selection
e90d275 
Since defaultProject is deprecated, the project must be determined differently. Variants:
- Use the defaultProject if given (for compatibility)
- Use the first project if only one is available
- Use the project defined by the --project arg.
- Throw an error.
@fmalcher
docs: add note about running ng-add manually
a7943ec
@fmalcher fmalcher mentioned this pull request Jun 17, 2022
Closed
JohannesHoppe
JohannesHoppe reviewed Jun 17, 2022
View reviewed changes
README.md
If you have multiple projects in one workspace, you can manually define the project name:

```sh
ng add angular-cli-ghpages --project MYPROJECTNAME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For later, it would be cool if we would have an interactive choice during installation.

@JohannesHoppe JohannesHoppe merged commit 1dc2067 into master Jun 17, 2022
@JohannesHoppe JohannesHoppe deleted the ngadd14 branch June 17, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesHoppe JohannesHoppe JohannesHoppe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular 14 support?
2 participants
@fmalcher @JohannesHoppe