Skip to content

Add PR feedback #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
dist
coverage
docs
1 change: 1 addition & 0 deletions .yarnrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
--add.exact true
7 changes: 0 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
# 10.0.0

- Supports Angular 7
- Requires Node >= 8
- Move to latest versions of major dependencies: typescript, immutable
- Moved documentation to docsify

# 9.0.0

## Breaking Changes
Expand Down
24 changes: 0 additions & 24 deletions docs/CONTRIBUTING.md

This file was deleted.

2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"packages": ["packages/*"],
"version": "10.0.0",
"version": "9.0.0",
"npmClient": "yarn",
"useWorkspaces": true,
"ignore": "example-app",
Expand Down
77 changes: 39 additions & 38 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"build:store": "yarn workspace @angular-redux/store build",
"build:form": "yarn workspace @angular-redux/form build",
"build:router": "yarn workspace @angular-redux/router build",
"release:canary": "lerna publish --canary --contents dist --dist-tag next",
"build:example-app": "yarn workspace example-app build",
"release:canary": "lerna publish --canary --contents dist --dist-tag next --npm-client npm",
"release:stable": "lerna version",
"release:stable:ci": "lerna publish from-git --contents dist",
"clean": "npm-run-all -p clean:*",
Expand Down Expand Up @@ -47,42 +48,42 @@
"node": ">=8"
},
"devDependencies": {
"@angular/animations": "^7.0.0",
"@angular/common": "^7.0.0",
"@angular/compiler": "^7.0.0",
"@angular/compiler-cli": "^7.0.0",
"@angular/core": "^7.0.0",
"@angular/forms": "^7.0.0",
"@angular/platform-browser": "^7.0.0",
"@angular/platform-browser-dynamic": "^7.0.0",
"@angular/router": "^7.0.0",
"@babel/core": "^7.0.0-0",
"@babel/types": "^7.2.2",
"@commitlint/cli": "^7.3.2",
"@commitlint/config-conventional": "^7.3.1",
"@commitlint/prompt-cli": "^7.3.1",
"@types/jest": "^23.1.13",
"babel-core": "^7.0.0-0",
"babel-jest": "^23.0.0",
"codelyzer": "^4.5.0",
"docsify-cli": "^4.3.0",
"husky": "^1.3.1",
"jest": "^23.6.0",
"jest-junit": "^6.0.1",
"jest-preset-angular": "^6.0.2",
"jest-zone-patch": "^0.0.10",
"lerna": "^3.10.6",
"lint-staged": "^8.1.0",
"ng-packagr": "^4.6.0",
"npm-run-all": "^4.1.3",
"prettier": "~1.15.3",
"redux": "^4.0.0",
"rimraf": "^2.6.2",
"rxjs": "^6.0.0",
"tsickle": "^0.34.0",
"tslib": "^1.9.0",
"tslint": "^5.12.1",
"typescript": "~3.2.0",
"zone.js": "~0.8.26"
"@angular/animations": "7.2.1",
"@angular/common": "7.2.1",
"@angular/compiler": "7.2.1",
"@angular/compiler-cli": "7.2.1",
"@angular/core": "7.2.1",
"@angular/forms": "7.2.1",
"@angular/http": "7.2.1",
"@angular/platform-browser": "7.2.1",
"@angular/platform-browser-dynamic": "7.2.1",
"@angular/router": "7.2.1",
"@babel/core": "7.2.2",
"@babel/types": "7.3.0",
"@commitlint/cli": "7.3.2",
"@commitlint/config-conventional": "7.3.1",
"@commitlint/prompt-cli": "7.3.1",
"@types/jest": "23.3.13",
"babel-jest": "23.6.0",
"codelyzer": "4.5.0",
"docsify-cli": "4.3.0",
"husky": "1.3.1",
"jest": "23.6.0",
"jest-junit": "6.0.1",
"jest-preset-angular": "6.0.2",
"jest-zone-patch": "0.0.10",
"lerna": "3.10.6",
"lint-staged": "8.1.0",
"ng-packagr": "4.6.0",
"npm-run-all": "4.1.5",
"prettier": "1.15.3",
"redux": "4.0.1",
"rimraf": "2.6.3",
"rxjs": "6.3.3",
"tsickle": "0.34.0",
"tslib": "1.9.3",
"tslint": "5.12.1",
"typescript": "3.2.4",
"zone.js": "0.8.28"
}
}
55 changes: 0 additions & 55 deletions packages/example-app/.angular-cli.json

This file was deleted.

51 changes: 11 additions & 40 deletions packages/example-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"build": "ng build --prod",
"e2e": "ng e2e",
"bootstrap": "npm-run-all bootstrap:*",
"bootstrap:store": "npm explore @angular-redux/store -- npm run build",
Expand All @@ -19,48 +17,21 @@
"node": ">=8"
},
"dependencies": {
"@angular-redux/form": "10.0.0",
"@angular-redux/router": "10.0.0",
"@angular-redux/store": "10.0.0",
"@angular/common": "^7.2.1",
"@angular/compiler": "^7.2.1",
"@angular/core": "^7.2.1",
"@angular/forms": "^7.2.1",
"@angular/http": "^7.2.1",
"@angular/platform-browser": "^7.2.1",
"@angular/platform-browser-dynamic": "^7.2.1",
"@angular/router": "^7.2.1",
"core-js": "^2.6.2",
"flux-standard-action": "^2.0.3",
"ramda": "^0.23.0",
"redux": "^4.0.0",
"redux-logger": "^3.0.1",
"redux-observable": "^1.0.0",
"rxjs": "^6.3.3",
"tslib": "^1.9.3",
"zone.js": "^0.8.27"
"@angular-redux/form": "9.0.1",
"@angular-redux/router": "9.0.0",
"@angular-redux/store": "9.0.0",
"core-js": "2.6.2",
"flux-standard-action": "2.0.3",
"ramda": "0.23.0",
"redux-logger": "3.0.6",
"redux-observable": "1.0.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "0.12.1",
"@angular/cli": "^7.2.1",
"@angular/compiler-cli": "^7.2.0",
"@angular/cli": "7.2.2",
"@angular/language-service": "7.2.0",
"@types/jasmine": "~2.8.8",
"@types/jasminewd2": "~2.0.3",
"@types/node": "10.12.18",
"@types/ramda": "0.24.18",
"@types/redux-logger": "3.0.6",
"codelyzer": "~4.5.0",
"jasmine-core": "~2.99.1",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~3.1.1",
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "~2.0.1",
"karma-jasmine": "~1.1.2",
"karma-jasmine-html-reporter": "^0.2.2",
"protractor": "~5.4.0",
"ts-node": "~7.0.0",
"tslint": "~5.11.0",
"typescript": "3.2.2"
"ts-node": "7.0.1"
}
}
30 changes: 0 additions & 30 deletions packages/example-app/protractor.conf.js

This file was deleted.

2 changes: 1 addition & 1 deletion packages/example-app/src/app/component.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ <h1>
{{ title }}
</h1>
<nav>
<a routerLink= "/elephants" routerLinkActive="active">Elephants</a>
<a routerLink="/elephants" routerLinkActive="active">Elephants</a>
<a routerLink="/lions" routerLinkActive="active">Lions</a>
<a routerLink="/feedback" routerLinkActive="active">Feedback</a>
</nav>
Expand Down
31 changes: 0 additions & 31 deletions packages/example-app/src/karma.conf.js

This file was deleted.

21 changes: 0 additions & 21 deletions packages/example-app/src/test.ts

This file was deleted.

23 changes: 0 additions & 23 deletions packages/example-app/src/tsconfig.json

This file was deleted.

9 changes: 0 additions & 9 deletions packages/example-app/src/tsconfig.spec.json

This file was deleted.

Loading