Skip to content

ReactiveConnectDirective bad input, formGroup form not set in ConnectBase #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 9 tasks
nanitohb opened this issue May 24, 2019 · 1 comment · Fixed by #94
Closed
2 of 9 tasks

ReactiveConnectDirective bad input, formGroup form not set in ConnectBase #85

nanitohb opened this issue May 24, 2019 · 1 comment · Fixed by #94
Labels
bug Something isn't working pkg: form Related to the form package

Comments

@nanitohb
Copy link

This is a...

  • feature request
  • bug report
  • usage question

What toolchain are you using for transpilation/bundling?

  • @angular/cli
  • Custom @ngTools/webpack
  • Raw ngc
  • SystemJS
  • Rollup
  • Other

Environment

NodeJS Version: 10
Typescript Version: 3.2.4
Angular Version: 7.2.15
@angular-redux/store version: 10.0.0
@angular/cli version: 7.3.9
OS: Windows

Expected Behaviour:

class ReactiveConnectDirective extends ConnectBase {
@input() formGroup: any; // Must be @input('formGroup') form: any;
...
}
because:

Actual Behaviour:

connect-base does not have the property form set and cannot reset and initialize.

Stack Trace/Error Message:

core.js:15724 ERROR Error: Uncaught (in promise): TypeError: Cannot read property 'control' of undefined
TypeError: Cannot read property 'control' of undefined
at ReactiveConnectDirective.push../node_modules/@angular-redux/form/fesm5/angular-redux-form.js.ConnectBase.resetState (angular-redux-form.js:660)
at angular-redux-form.js:572

@nanitohb
Copy link
Author

Sorry forgot to say in angular-redux/[email protected]

@smithad15 smithad15 added bug Something isn't working pkg: form Related to the form package labels Jul 7, 2019
github-actions bot pushed a commit to adrianiy/platform that referenced this issue Sep 28, 2021
# ngredux-form-v1.0.0 (2021-09-28)

### Bug Fixes

* external tslint running on library source code ([angular-redux#35](https://github.com/AdrianInsua/platform/issues/35)) ([d6c6745](d6c6745))
* fix eslint ([ab4d1d3](ab4d1d3))
* fix package linking ([56354a5](56354a5))
* **form:** connect formGroup input not mapped to connect base ([angular-redux#94](https://github.com/AdrianInsua/platform/issues/94)) ([9d1d6db](9d1d6db)), closes [angular-redux#85](https://github.com/AdrianInsua/platform/issues/85)
* add typescript unused checks ([angular-redux#32](https://github.com/AdrianInsua/platform/issues/32)) ([65c4229](65c4229))
* reactive forms not updating on changes in store ([angular-redux#41](https://github.com/AdrianInsua/platform/issues/41)) ([bd87846](bd87846))
* rm WeakMap, we can't use it for key with type string ([angular-redux#15](https://github.com/AdrianInsua/platform/issues/15)) ([6a9bdc2](6a9bdc2))
* typings entry point and failing definitions ([angular-redux#36](https://github.com/AdrianInsua/platform/issues/36)) ([ae0373d](ae0373d))
* update peer dependencies from ^9.0.0 to ^10.0.0 ([angular-redux#87](https://github.com/AdrianInsua/platform/issues/87)) ([fcea502](fcea502))

### chore

* **build:** use ng-packagr ([angular-redux#37](https://github.com/AdrianInsua/platform/issues/37)) ([dffe23a](dffe23a)), closes [angular-redux#9](https://github.com/AdrianInsua/platform/issues/9)
* **linting:** add global tslint rules ([angular-redux#35](https://github.com/AdrianInsua/platform/issues/35)) ([336cc60](336cc60)), closes [angular-redux#4](https://github.com/AdrianInsua/platform/issues/4)

### Features

* add bootstraping script ([3fd7b32](3fd7b32))
* add peer dep support for Angular 5 ([angular-redux#51](https://github.com/AdrianInsua/platform/issues/51)) ([13b4cb8](13b4cb8))
* bump angular version to 11.0.5 ([1b8bb72](1b8bb72))
* refactor packages to match new ng-packager ([710edef](710edef))
* split directives into separate modules ([angular-redux#37](https://github.com/AdrianInsua/platform/issues/37)) ([6250ea8](6250ea8))
* upgrade to angular 7 ([angular-redux#72](https://github.com/AdrianInsua/platform/issues/72)) ([18d9245](18d9245)), closes [angular-redux#65](https://github.com/AdrianInsua/platform/issues/65) [angular-redux#66](https://github.com/AdrianInsua/platform/issues/66) [angular-redux#67](https://github.com/AdrianInsua/platform/issues/67) [angular-redux#68](https://github.com/AdrianInsua/platform/issues/68) [angular-redux#69](https://github.com/AdrianInsua/platform/issues/69) [angular-redux#70](https://github.com/AdrianInsua/platform/issues/70) [angular-redux#71](https://github.com/AdrianInsua/platform/issues/71) [angular-redux#74](https://github.com/AdrianInsua/platform/issues/74) [angular-redux#79](https://github.com/AdrianInsua/platform/issues/79)

### BREAKING CHANGES

* Upgrades Angular dependencies to v7
* **build:** - changes the output to conform to the Angular Package Format. This may cause subtle differences in consumption behaviour
- peer dependencies have been corrected to actual dependencies
* **linting:** - ConnectArray has been renamed to ConnectArrayDirective
- ReactiveConnect has been renamed to ReactiveConnectDirective
- Connect has been renamed to ConnectDirective
- interfaces with an "I" prefix have had that prefix removed (e.g "IAppStore" -> "AppStore")
github-actions bot pushed a commit to adrianiy/platform that referenced this issue Sep 28, 2021
# @adrian.insua/ngredux-form-v1.0.0 (2021-09-28)

### Bug Fixes

* add typescript unused checks ([angular-redux#32](https://github.com/AdrianInsua/platform/issues/32)) ([65c4229](65c4229))
* change package names to be user scoped ([c0c9d1d](c0c9d1d))
* fix eslint ([ab4d1d3](ab4d1d3))
* fix package linking ([56354a5](56354a5))
* **form:** connect formGroup input not mapped to connect base ([angular-redux#94](https://github.com/AdrianInsua/platform/issues/94)) ([9d1d6db](9d1d6db)), closes [angular-redux#85](https://github.com/AdrianInsua/platform/issues/85)
* external tslint running on library source code ([angular-redux#35](https://github.com/AdrianInsua/platform/issues/35)) ([d6c6745](d6c6745))
* reactive forms not updating on changes in store ([angular-redux#41](https://github.com/AdrianInsua/platform/issues/41)) ([bd87846](bd87846))
* rm WeakMap, we can't use it for key with type string ([angular-redux#15](https://github.com/AdrianInsua/platform/issues/15)) ([6a9bdc2](6a9bdc2))
* typings entry point and failing definitions ([angular-redux#36](https://github.com/AdrianInsua/platform/issues/36)) ([ae0373d](ae0373d))
* update peer dependencies from ^9.0.0 to ^10.0.0 ([angular-redux#87](https://github.com/AdrianInsua/platform/issues/87)) ([fcea502](fcea502))

### chore

* **build:** use ng-packagr ([angular-redux#37](https://github.com/AdrianInsua/platform/issues/37)) ([dffe23a](dffe23a)), closes [angular-redux#9](https://github.com/AdrianInsua/platform/issues/9)
* **linting:** add global tslint rules ([angular-redux#35](https://github.com/AdrianInsua/platform/issues/35)) ([336cc60](336cc60)), closes [angular-redux#4](https://github.com/AdrianInsua/platform/issues/4)

### Features

* add bootstraping script ([3fd7b32](3fd7b32))
* add peer dep support for Angular 5 ([angular-redux#51](https://github.com/AdrianInsua/platform/issues/51)) ([13b4cb8](13b4cb8))
* bump angular version to 11.0.5 ([1b8bb72](1b8bb72))
* refactor packages to match new ng-packager ([710edef](710edef))
* split directives into separate modules ([angular-redux#37](https://github.com/AdrianInsua/platform/issues/37)) ([6250ea8](6250ea8))
* upgrade to angular 7 ([angular-redux#72](https://github.com/AdrianInsua/platform/issues/72)) ([18d9245](18d9245)), closes [angular-redux#65](https://github.com/AdrianInsua/platform/issues/65) [angular-redux#66](https://github.com/AdrianInsua/platform/issues/66) [angular-redux#67](https://github.com/AdrianInsua/platform/issues/67) [angular-redux#68](https://github.com/AdrianInsua/platform/issues/68) [angular-redux#69](https://github.com/AdrianInsua/platform/issues/69) [angular-redux#70](https://github.com/AdrianInsua/platform/issues/70) [angular-redux#71](https://github.com/AdrianInsua/platform/issues/71) [angular-redux#74](https://github.com/AdrianInsua/platform/issues/74) [angular-redux#79](https://github.com/AdrianInsua/platform/issues/79)

### BREAKING CHANGES

* Upgrades Angular dependencies to v7
* **build:** - changes the output to conform to the Angular Package Format. This may cause subtle differences in consumption behaviour
- peer dependencies have been corrected to actual dependencies
* **linting:** - ConnectArray has been renamed to ConnectArrayDirective
- ReactiveConnect has been renamed to ReactiveConnectDirective
- Connect has been renamed to ConnectDirective
- interfaces with an "I" prefix have had that prefix removed (e.g "IAppStore" -> "AppStore")
github-actions bot pushed a commit to adrianiy/platform that referenced this issue Sep 28, 2021
# [10.1.0](v10.0.0...v10.1.0) (2021-09-28)

### Bug Fixes

* change package names to be user scoped ([c0c9d1d](c0c9d1d))
* fix eslint ([ab4d1d3](ab4d1d3))
* fix locks ([3cbefb3](3cbefb3))
* fix package linking ([56354a5](56354a5))
* fix yarn registry ([1e831b1](1e831b1))
* update lock ([4bc2fee](4bc2fee))
* **form:** connect formGroup input not mapped to connect base ([angular-redux#94](https://github.com/AdrianInsua/platform/issues/94)) ([9d1d6db](9d1d6db)), closes [angular-redux#85](https://github.com/AdrianInsua/platform/issues/85)
* update peer dependencies from ^9.0.0 to ^10.0.0 ([angular-redux#87](https://github.com/AdrianInsua/platform/issues/87)) ([fcea502](fcea502))

### Features

* add bootstraping script ([3fd7b32](3fd7b32))
* add semantic-release package ([d95d90c](d95d90c))
* add semantic-release script ([952c1de](952c1de))
* bump angular version to 11.0.5 ([1b8bb72](1b8bb72))
* refactor packages to match new ng-packager ([710edef](710edef))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg: form Related to the form package
Development

Successfully merging a pull request may close this issue.

2 participants