Use Babel 6 in loose mode to build JS #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using loose mode prevents disables referencing Symbol in built JS. While the loose mode could cause subtle bugs, it currently only affects one for-of loop. Requiring babel-polyfill for that would be wasteful.
|
Seconding this (or at least, any solution that gets rid of Symbol from the build) - currently trying to load an ng-redux application in IE 11 is throwing errors because of Symbol being undefined, and loading the whole polyfill feels like a massive expense considering none of my own code requires it. |
wbuchwalter
added a commit
that referenced
this pull request
Jan 14, 2016
Use Babel 6 in loose mode to build JS
|
@lautis 👍 Thanks, nice catch! |
|
Released under |
|
Thanks to both of you! 👍 |
|
Thanks for fixing this. I updated some packages last week and IE11 started choking with this error. I was a bit puzzled about where it was coming from, but this fix took care of it. |
|
Glad it helped! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using loose mode prevents disables referencing Symbol in built JS. While the loose mode could cause subtle bugs, it currently only affects one for-of loop. Requiring babel-polyfill for that would be wasteful.