Skip to content

Fix: update typings to fit with umd module #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

jrakotoharisoa
Copy link
Contributor

@jrakotoharisoa jrakotoharisoa commented Aug 29, 2017

Now we should be able to import ng-redux v3.5.x UMD module in typescript like this :

import * as ngRedux from "ngRedux";

Issue #153

@AntJanus AntJanus added this to the 4.0.0 milestone Aug 29, 2017
@AntJanus
Copy link
Collaborator

@jrakotoharisoa awkward question. How do I test that this works as intended?

@AntJanus AntJanus modified the milestones: 3.5.1, 4.0.0 Aug 31, 2017
@jrakotoharisoa
Copy link
Contributor Author

@AntJanus You can test with this repo : https://github.com/jrakotoharisoa/ng-redux-typescript-test

After a npm install, run npm start.
A typescript error occured due to wrong typings of v3.5.0.

Try to use the updated version of ng-redux/index.d.ts then it should works.

@AntJanus
Copy link
Collaborator

@jrakotoharisoa 👍 thanks! I'll give that a shot :)

@AntJanus AntJanus merged commit e1973f7 into angular-redux:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants