Skip to content

fix: Replace lodash assign with Object.assign for symbol copy #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
},
"dependencies": {
"invariant": "^2.1.0",
"lodash.assign": "^3.2.0",
"lodash.curry": "^4.0.1",
"lodash.isarray": "^3.0.4",
"lodash.isfunction": "^3.0.6",
Expand Down
2 changes: 1 addition & 1 deletion src/components/connector.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import invariant from 'invariant';
import isPlainObject from 'lodash.isplainobject';
import isFunction from 'lodash.isfunction';
import isObject from 'lodash.isobject';
import assign from 'lodash.assign';

const assign = Object.assign;
const defaultMapStateToTarget = () => ({});
const defaultMapDispatchToTarget = dispatch => ({dispatch});

Expand Down
2 changes: 1 addition & 1 deletion src/components/ngRedux.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import invariant from 'invariant';
import {createStore, applyMiddleware, compose, combineReducers} from 'redux';
import digestMiddleware from './digestMiddleware';

import assign from 'lodash.assign';
import curry from 'lodash.curry';
import isArray from 'lodash.isarray';
import isFunction from 'lodash.isfunction';
Expand All @@ -12,6 +11,7 @@ import map from 'lodash.map';
const typeIs = curry((type, val) => typeof val === type);
const isObject = typeIs('object');
const isString = typeIs('string');
const assign = Object.assign;

export default function ngReduxProvider() {
let _reducer = undefined;
Expand Down
3 changes: 2 additions & 1 deletion test/components/connector.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ let sinon = require('sinon');
import { createStore } from 'redux';
import Connector from '../../src/components/connector';
import isFunction from 'lodash.isfunction';
import assign from 'lodash.assign';

const assign = Object.assign;

describe('Connector', () => {
let store;
Expand Down