preserve Symbol(observable) when connecting the store #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the object created by redux createStore has a key of Symbol(observable). $ngRedux's provider looses that key when connecting the store. As a result, we can't use $ngRedux's store in ng2Redux's provideStore. angular-redux/store#256
AntJanus
reviewed
Jul 26, 2017
| @@ -78,7 +78,8 @@ export default function ngReduxProvider() { | |||
| ? applyMiddleware(...resolvedMiddleware)(finalCreateStore)(_reducer, _initialState) | |||
| : applyMiddleware(...resolvedMiddleware)(finalCreateStore)(_reducer); | |||
|
|
|||
| return assign({}, store, { connect: Connector(store) }); | |||
| store.connect = Connector(store); | |||
There was a problem hiding this comment.
It looks like _.assign does not copy over Symbols. Can you change this PR to remove assign and use Object.assign instead? That should copy it over while keeping everything immutable as before.
10 tasks
|
I'll go ahead and close this out due to inactivity. Thanks for bringing attention to the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm migrating an AngularJS app to Angular. The idea is to have ng-redux and ng2-redux share the same store.
This is how I bootstrap my Angular app:
But the I get
TypeError: object is not observable.The object created by Redux's
createStorehas a key ofSymbol(observable). Butng-redux's provider looses that key when connecting the store.The aim of this pull request is to preserve the object created by Redux and augment it with the
connectproperty.