Skip to content

Injectable store enhancers #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iamFIREcracker opened this issue Jul 19, 2016 · 3 comments
Closed

Injectable store enhancers #98

iamFIREcracker opened this issue Jul 19, 2016 · 3 comments

Comments

@iamFIREcracker
Copy link
Contributor

Where do you stand on changing ngReduxProvider.$get() implementation to support store enhancers being specified as strings (ie. injectable services, a la middlewares)? If interested I could submit a PR.
@wbuchwalter
Copy link
Member

I don't see any problem with that off the top of my head.
So I would say PR welcome :)

@iamFIREcracker
Copy link
Contributor Author

And PR it is: #99 ;-)

@wbuchwalter
Copy link
Member

Sorry for the delay, busy times on my side.
Since I have no time at all to test the changes, I have released this under 3.4.0-beta1.
Please try that for some times, and if everything works fine let me know and I will release properly.
Keep in mind that this release also includes #89 .
Thank you.

P.S: I'm looking for collaborators for this repos, since I have a hard time supporting it alone now. If you are interested ping me on twitter or at wbuchwalter at gmail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamFIREcracker @wbuchwalter