Skip to content

3.5.0 fails in PhantomJS without Object.assign polyfill #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Nagogus opened this issue Aug 28, 2017 · 0 comments
Closed

3.5.0 fails in PhantomJS without Object.assign polyfill #152

Nagogus opened this issue Aug 28, 2017 · 0 comments
Labels
bug
Milestone
3.5.1

Comments

@Nagogus
Copy link

Nagogus commented Aug 28, 2017

FYI

As lodash assign method was replaced by Object.assign all tests using phantomjs as browser start to fail.
TypeError: undefined is not a constructor (evaluating 'assign({}, store, { connect: Connector(store) })')

Can be fixed by downgrading to 3.4.1 or using phantomjs-polyfill-object-assign
@deini deini added the bug label Aug 29, 2017
@AntJanus AntJanus added this to the 3.5.1 milestone Aug 29, 2017
@deini deini mentioned this issue Sep 1, 2017
Closed
graingert pushed a commit to graingert/ng-redux that referenced this issue Sep 4, 2017
switch to babel transform runtime Fixes angular-redux#152
90c9f07 
This allows the use of Object.assign
@graingert graingert mentioned this issue Sep 4, 2017
Merged
@deini deini closed this as completed in 7fbdc10 Sep 4, 2017
deini added a commit that referenced this issue Sep 4, 2017
@deini
Merge pull request #161 from graingert/babel-transform-runtime
8464d92 
switch to babel transform runtime Fixes #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.5.1
Development

No branches or pull requests
3 participants
@AntJanus @Nagogus @deini