Updates for stricter TSConfig settings. #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately `noUnusedLocals` and `noUnusedParameters` cause propblems for AoT and `@Output`-related EventEmitters. See angular/angular#17131 Once that's fixed in Angular itself then we can turn those checks back on here. Note that they work already in JiT mode.
SethDavenport
force-pushed
the
chore/tsconfig-settings
branch
from
e663dc7 to
b927bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
noUnusedLocalsandnoUnusedParameterscause propblems for AoT and@Output-related EventEmitters. See angular/angular#17131Once that's fixed in Angular itself then we can turn those checks back on here. Note that they work already in JiT mode.