Use example.com rather than privately registered domain names #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this |
|
Cool, I think this looks good too! 👍 |
|
Changes LGTM. One thing though, @ShaneKilkelly would you mind adjusting the commit messages according to the contributing guide? It allows the project's changelog to be generated from the messages. |
|
Right, I think it would be easier to close this issue, redo the commits and open an new PR once I've got a clean set of changes to merge in. Thanks for the pointer to the contribution guide, it slipped my mind initially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the seed data file uses
test.comandadmin.comfor the email addresses of the two default user accounts. This struck me as a mistake, as both domains are registered and are not really suitable for use in example data.Generally it is preferable to use the
example.comwhen dealing with example data, as the domain is reserved explicitly for this purpose.The two commits in this Pull Request update the seed data file to use the
example.comdomain, and updates the documentation on the login page to use the new domain.