feat (mongoose): use mongoose-bird to promisify the mongoose API #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var _ = require('lodash');<% if (filters.mongoose) { %> | ||
| var Thing = require('./thing.model');<% } %> | ||
| var _ = require('lodash'); | ||
| var Thing = require('./thing.model'); |
There was a problem hiding this comment.
@kingcody I noticed that you have removed the <% if (filters.mongoose) { %> from around the var Thing = require('./thing.model'); ... and in some other places also.
This is required so when the mongoose option is turned off in the generator this line is not generated in the final output.
DaftMonk
added a commit
that referenced
this pull request
Sep 14, 2014
feat (mongoose): use mongoose-bird to promisify the mongoose API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of @pentateu's mongoose-bird PR, rebased onto
canary.Main purpose is to demonstrate the rebase changes. Can be closed in favor of #503.