chore(server): Update to sequelize 4 #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Awk34
requested changes
Jul 23, 2018
| }); | ||
| }); | ||
| beforeBulkCreate(users, fields) { | ||
| return sequelize.Promise.map(users, user => user.updatePassword()); |
There was a problem hiding this comment.
Does this not work if you just use the global Promise built into Node?
| * @api public | ||
| */ | ||
| User.prototype.updatePassword = function() { | ||
| var user = this; |
There was a problem hiding this comment.
The alias for this seems unnecessary here
Update sequelize to v4 and fix the user model to work with this. Part of angular-fullstack#2691
Awk34
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sequelize to v4 and fix the user model to work with this.
Part of #2691
generator-angular-fullstack$ npm test)