Skip to content

Typings build #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2016
Merged

Typings build #2120

merged 2 commits into from
Aug 5, 2016

Conversation

Koslun
Copy link
Member

@Koslun Koslun commented Aug 5, 2016

Pushing towards master since easy but seemingly critical fixes and canary seems a bit outdated.

Koslun added 2 commits August 5, 2016 13:11
The typings task was erroneously included in the gulp build even in non-typescript scaffolds.

fixes #2110
TS somehow started emitting the type errors as errors that are then propagating to webpack and finally gulp. Thus need to catch and recover from thrown errors.

closes  #2039, #2110
@Awk34 Awk34 merged commit f9c75e7 into master Aug 5, 2016
@Koslun Koslun mentioned this pull request Aug 8, 2016
1 task
@Awk34 Awk34 deleted the typings-build branch August 11, 2016 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants