-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(gen:app): remove bower, initial webpack support #1892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Awesome job so far! Truly a tremendous amount of changes! Wanted to see if I could help some but couldn't get Biggest issue was webpack not rendering an Snapshot of console output for gulp-ts-ui-router-mocha:
With TypeScript there were additionally a lot of complaints about So thinking the module loading is either broken or not implemented yet, then failing to render is either a side-effect of that or another bug or incomplete feature. Is this working at your end, or did you just mark the check boxes to show that you've begun working on fixing those particular aspects? And are you iterating too fast for it to be worthwhile for me to debug/help out or should I hold off until it's more ready? |
So I added code to the gen to replace all angular ES6 imports with regular The checkboxes are more for me. Those are the one's I've gotten a minimal working version of locally. (I've been ignoring TS type errors for now) Feel free to help out, though. I'm probably going to end up taking out he Grunt file and only supporting Gulp.. |
Weird because prior to moving to typings I think I got the TS compiler to recognize the Angular modules used through tsd, i.e. on definitely typed. Had to copy the
So is the If it's working, could you maybe just send over the rendered version of Can look at it later today or tomorrow then I think.
Sounds good, agree with the points raised in #1869. |
28737b8
to
3f95625
Compare
Oops, this PR should be against canary |
Grunt