Skip to content

chore(gen): update to Babel 6 #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2016
Merged

chore(gen): update to Babel 6 #1705

merged 2 commits into from
Mar 17, 2016

Conversation

Awk34
Copy link
Member

@Awk34 Awk34 commented Mar 12, 2016

No description provided.

@Awk34 Awk34 self-assigned this Mar 12, 2016
@Awk34 Awk34 force-pushed the chore/gen-babel-6 branch 4 times, most recently from 2ea6334 to 3052c1a Compare March 12, 2016 14:58
@Awk34 Awk34 force-pushed the chore/gen-babel-6 branch from 3052c1a to fdd8bdf Compare March 12, 2016 15:16
@amercier
Copy link

@Awk34 Looks like a lot of code is relying on the default export to be assigned module.export. I assume that's the reason why you added .default (when possible) or module.exports = (when not).

Wouldn't it make more sense to use the add-module-exports plugin, instead of manually adding all these .default/module.exports =?

@Awk34
Copy link
Member Author

Awk34 commented Mar 14, 2016

@amercier It's not a pretty solution, but I just did it to get things working.

I don't think using that plugin is a good idea. Anything that will be imported using CommonJS should be exported using CommonJS; the same goes for ES imports/exports. .default is just an ugly fix for mixing different module syntaxes. The mixed syntaxes should be ironed out. Using a sort of monkey-patch Babel plugin is a bad idea.

Awk34 added a commit that referenced this pull request Mar 17, 2016
@Awk34 Awk34 merged commit a3b9b48 into master Mar 17, 2016
@amercier
Copy link

@Awk34 Awesome! And thanks for your response, that makes sense.

@Awk34 Awk34 deleted the chore/gen-babel-6 branch March 17, 2016 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants