Skip to content

Dependency version care in _bower.json #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2014

Conversation

delight
Copy link
Contributor

@delight delight commented Mar 30, 2014

  • adjusts bower.json to allways depend on the latest stable 1.2.x release of angular
  • bumps version of bootstrap to match with the version of bootstrap-sass-official

- adjusts bower.json to allways depend on the latest stable 1.2.x release of angular
- bumps version of bootstrap to match with the version of bootstrap-sass-official
@DaftMonk
Copy link
Member

With the new bower version this works great, however for anyone using an older version of bower, it will incorrectly fetch the latest snapshots.

What do you think would be the best way to deal with that? We could add a peerDependency on bower 1.3, or should we just tell people to update their bower?

@delight
Copy link
Contributor Author

delight commented Mar 30, 2014

To be honest I think ppl in JS world have "versionitis" therefor they are always looking for the latest and greatest. So the danger that ppl would use an old version of bower should be pretty minor.

Avoiding pitfalls and keeping barriers low is always a good design. A peerDependency sounds pretty solid - but a note about npm -g update bower should be adequate. At the end we are talking about developers.

So IMO its better to teach the people about maintaining the requirements versus having it simply work and let people wonder why that is.

On the other hand I don't know how many devs know to use there tools ? npm -g outdated etc. ?

DaftMonk added a commit that referenced this pull request Apr 13, 2014
Dependency version care in _bower.json
@DaftMonk DaftMonk merged commit b5eef18 into angular-fullstack:master Apr 13, 2014
@delight delight deleted the dep-management branch April 13, 2014 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants