fix(gulp): add babel runtime options #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use the |
| @@ -392,7 +395,7 @@ gulp.task('build:client', ['transpile:client', 'styles', 'html'], () => { | |||
|
|
|||
| let assets = plugins.useref.assets({searchPath: ['client', '.tmp']}); | |||
|
|
|||
| return gulp.src(paths.mainView)<% if(filters.jade) { %> | |||
There was a problem hiding this comment.
split this change out to a separate commit, since it's unrelated to the other changes
There was a problem hiding this comment.
Would you like a new PR, or just a separate commit? (sorry, pretty new to this)
There was a problem hiding this comment.
Just pull it into a separate commit. If you know how to rebase, I'd suggest it. If not, just make a new PR.
without `es7.classProperties`, babel won't compile the default controller template
update `build:client` so that `gulp.src` points to `paths.client.mainView`
Awk34
added a commit
that referenced
this pull request
Dec 8, 2015
fix(gulp): add babel runtime options, fix a path
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without
es7.classProperties, babel won't compile the default controller template