Skip to content

feat(gen): always use Babel #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2015
Merged

feat(gen): always use Babel #1312

merged 1 commit into from
Sep 17, 2015

Conversation

Awk34
Copy link
Member

@Awk34 Awk34 commented Sep 15, 2015

leave in supporting code for use with eventually supporting typescript

@Awk34 Awk34 added this to the 3.0.0 milestone Sep 15, 2015
@Awk34 Awk34 force-pushed the gen-default-babel branch 2 times, most recently from 070a2bb to 97d4d6f Compare September 15, 2015 20:15
@Awk34 Awk34 mentioned this pull request Sep 15, 2015
@kingcody
Copy link
Member

We still need to set filters.js since ng-component uses it (else, it won't generate any scripts).

@kingcody
Copy link
Member

If we're looking to support typescript, maybe we should just leave the (js) filter in file names for now?

@Awk34
Copy link
Member Author

Awk34 commented Sep 16, 2015

I don't think we'll need it

@kingcody
Copy link
Member

I don't think we'll need it

In reply to (js) or filters.js?

@Awk34
Copy link
Member Author

Awk34 commented Sep 16, 2015

(js)

@kingcody
Copy link
Member

@Awk34 I rebased this.

leave in supporting code for use with eventually supporting typescript
@kingcody
Copy link
Member

I'm sure sauce labs will fail initially with too many concurrent tests...

@kingcody kingcody mentioned this pull request Sep 17, 2015
kingcody added a commit that referenced this pull request Sep 17, 2015
@kingcody kingcody merged commit 10b5179 into canary Sep 17, 2015
@Awk34 Awk34 deleted the gen-default-babel branch December 14, 2015 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants