Feature: auth module #1309
Merged
Feature: auth module #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * move remaining auth code from app.js to auth module * the router param `authenticate` now accepts a string as a role requirement * admin route now uses role based auth
| } | ||
|
|
||
| angular.module('<%= scriptAppName %>') | ||
| .controller('MainController', MainController); | ||
|
|
||
| })(); |
There was a problem hiding this comment.
We should keep this tabbed the way it was. The IIFE shouldn't mess with our code's formatting.
kingcody
force-pushed
the
feature/auth-module
branch
from
26f92c8 to
abcb51a
Compare
|
Four issues in one PR? You should get a medal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
injector:scriptssorts*.module.jsfirstAuth.hasRoleUtilserviceAuthorizationheader to same origin