Skip to content

Express v4.x #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2014
Merged

Express v4.x #130

merged 2 commits into from
Apr 13, 2014

Conversation

mrzepinski
Copy link
Contributor

No description provided.

@mrzepinski mrzepinski mentioned this pull request Mar 15, 2014
@MariusRumpf
Copy link

Line 37 seems to be missing the part to the views.
Correct: app.set('views', config.root + '/app/views');
Now: app.set('views', config.root + '/app');

I get an error otherwise:
Error: Failed to lookup view "index" in views directory

@mrzepinski
Copy link
Contributor Author

@MariusRumpf thanks ;) I've changed my app structure to Google style, and I forgot correct this url later. My fix is here right now ;)

@DaftMonk
Copy link
Member

Looks good, but I want to wait till express 4.0 gets officially released before upgrading. I'll hang onto this PR for future reference. Thanks for your work! :)

@DaftMonk
Copy link
Member

Now that express 4.0 is out, i will look at merging this asap.

@DaftMonk DaftMonk merged commit 81380d4 into angular-fullstack:master Apr 13, 2014
@DaftMonk
Copy link
Member

👍

@mrzepinski
Copy link
Contributor Author

@DaftMonk thanks :) Next change - Google app structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants