fix(gen): force config update when it exists and skipConfig == false
#1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.filters = this._.defaults(this.config.get('filters'), { | ||
| bootstrap: true, | ||
| uibootstrap: true, | ||
| jasmine: true |
There was a problem hiding this comment.
@Awk34 I'm wondering if we even need to be setting the defaults here. I assume they are for migration purposes, can you think of any other reasons, use cases?
There was a problem hiding this comment.
Hmm, I think you're right. I can't think of any other purpose either.
There was a problem hiding this comment.
Hmm, test fix? Try removing that code and running the tests.
kingcody
force-pushed
the
fix/force-new-config
branch
from
f5177f7 to
b370180
Compare
|
All checks out, probably since I update the fixtures config earlier to be |
|
👍 |
Awk34
added a commit
that referenced
this pull request
Sep 7, 2015
fix(gen): force config update when it exists and `skipConfig == false`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires DaftMonk/generator-ng-component#21