feat(app): improved socket.io logging #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ function onDisconnect(socket) { | |||
| function onConnect(socket) { | |||
| // When the client emits 'info', this listens and executes | |||
| socket.on('info', function(data) { | |||
| console.info('[%s] %s', socket.address, JSON.stringify(data, null, 2)); | |||
| console.info(`SocketIO ${socket.nsp.name} [${socket.address}] ${JSON.stringify(data, null, 2)}`); | |||
There was a problem hiding this comment.
This line needs to be <=100.
|
@Awk34 what do you think about this change? (sans jscs failure) |
|
LGTM |
|
Sounds good, I'll fix the line length. |
kingcody
force-pushed
the
feature/improve-socketio-logging
branch
from
e661950 to
c1fd93f
Compare
|
@Awk34 check it again, I added a |
Awk34
added a commit
that referenced
this pull request
Sep 2, 2015
feat(app): improved socket.io logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.