Skip to content

refactor($http): change legacy promise to standard #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2015

Conversation

jkiimm
Copy link
Contributor

@jkiimm jkiimm commented Aug 25, 2015

success and error promise have been deprecated.

resolves #1200

@Awk34
Copy link
Member

Awk34 commented Aug 25, 2015

This brings up the fact that the JS admin.controller file uses User.query, while the CoffeeScript one uses $http. I'm going to fix the CoffeeScript one. Just remove your changes to admin.controller(coffee).coffee.

@Awk34
Copy link
Member

Awk34 commented Aug 25, 2015

Requires #1211

@Awk34 Awk34 added this to the 3.0.0 milestone Aug 25, 2015
`success` and `error` promise have been deprecated.
@jkiimm
Copy link
Contributor Author

jkiimm commented Aug 25, 2015

Oh, I didn't catch that, thank you. I just remove that coffee file. @Awk34

@Awk34
Copy link
Member

Awk34 commented Aug 25, 2015

Awesome, thanks :D

Awk34 added a commit that referenced this pull request Aug 25, 2015
refactor($http): change legacy promise to standard
@Awk34 Awk34 merged commit 3d9c926 into angular-fullstack:canary Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants