Skip to content

Fix: update socketio & doc info #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2015

Conversation

kingcody
Copy link
Member

Changes:

  • Update socket.io and related deps
  • Update socketio-jwt doc comment
  • Update socket.address reference

Awk34 added a commit that referenced this pull request Aug 14, 2015
fix(socketio): update socketio & doc info
@Awk34 Awk34 merged commit a1f784b into angular-fullstack:canary Aug 14, 2015
@kingcody kingcody deleted the fix/update-socketio-info branch August 15, 2015 01:35
@kingcody kingcody restored the fix/update-socketio-info branch August 15, 2015 03:22
@kingcody
Copy link
Member Author

@Awk34 looks like this PR disappeared somehow.

@Awk34
Copy link
Member

Awk34 commented Aug 15, 2015

I am confuse

@kingcody
Copy link
Member Author

The two commits that are listed here are not included in the canary commit history.

@Awk34
Copy link
Member

Awk34 commented Aug 15, 2015

haha yeah that's why I'm confused

@kingcody
Copy link
Member Author

I can just re submit these two PRs.

@kingcody kingcody deleted the fix/update-socketio-info branch September 1, 2015 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants