feat(app): implement oauth-buttons directive #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingcody
force-pushed
the
feature/oauth-buttons
branch
from
e238bc9 to
8c8c30b
Compare
kingcody
force-pushed
the
feature/oauth-buttons
branch
from
8c8c30b to
8222699
Compare
| @@ -22,7 +22,8 @@ | |||
| "console": true, | |||
| "$": true, | |||
| "_": true, | |||
| "moment": true, | |||
| "moment": true,<% if (filters.jasmine) { %> | |||
| "jasmine": true,<% } %> | |||
There was a problem hiding this comment.
This should be in a separate commit
|
I took the time to go back through this. Apart from moving those two JSHint things to a separate commit, it LGTM. Nice work with all the tests for it too. |
kingcody
force-pushed
the
feature/oauth-buttons
branch
from
8222699 to
8e21ce9
Compare
|
|
Awk34
added a commit
that referenced
this pull request
Sep 8, 2015
feat(app): implement oauth-buttons directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
oauth-buttonto directive and provide spec/e2e test<% does() %>now accepts yeoman escaped template stringsbootstrap-socialwhenfilters.bootstrap == true