Update passport auth api #1062
Update passport auth api #1062
Conversation
Facebook removed most default info. Must now explicitly ask for email. They also do not send usernames anymore.
The following scopes are no longer supported: - https://www.googleapis.com/auth/userinfo.profile - https://www.googleapis.com/auth/userinfo.email Use the following in place - profile - email Passport also does not provide the username, but we can get it from the email.
|
@adamk33n3r thank you very much. |
fix(oauth): update google/fb passport
|
@kingcody you're welcome. I'm glad to provide value to something I love using. |
|
Thanks @adamk33n3r . Feel free to continue to open PRs :D Also feel free to contact me on Gitter.im |
|
So guys, I'm wondering if we should remove the Also, what is the current situation of a user signing in with twitter? Since we don't get an email address does our user registration fail with model validation errors? |
|
@kingcody I can confirm Twitter still works. If you look at https://github.com/DaftMonk/generator-angular-fullstack/blob/canary/app/templates/server/api/user(auth)/user.model(mongooseModels).js#L59 it returns true is you are using an oauth provider, no matter if email is set or not. |
|
I'll chat you guys on Gitter |
There have been some API changes.
As of July 8th Facebook introduced v2.4 of their API. The default request only responds with id and name now.
If you create a Facebook app after July 8th you are forced to use v2.4 so this breaks the app (even though passport is currently defaulted to use v2.2, Facebook forces you).
Google has deprecated the use of
https://www.googleapis.com/auth/userinfo.profileandhttps://www.googleapis.com/auth/userinfo.email. You should now useprofileandemail.