-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test-file-creation.js is not windows aware #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good call @gintsgints, we'll use |
Let me try to take care on this as I have windows to test :) |
Absolutely! Big thanks 👍 |
Can you please let me know why expected is left empty - err.expected = ''; |
Nope, it's for the mocha text diff feature. That way unexpected files show up as red in an error report. |
Yeah but I do not see expected ones in green :) |
I would change this to - |
I see, matter of preference I guess. I didn't want to have to sift through all those files and instead I only wanted to see the ones that were extra, but I'm open to a change. Perhaps see what others have to say on the matter? |
Ok. I will just suggest PR. |
Sounds good |
Please review and test in linux #602 |
- change function assertOnlyFiles to use a different local variable from global module name - path. - show expected files when a test fails - use path.normalize before search in the array Closes #601
Expected files should be generated windows aware for slashes.
Also local variable path should not be used in function - assertOnlyFiles
(because this is node global variable for path module)
The text was updated successfully, but these errors were encountered: