-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Bootstrap variables still get included #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In the mean time you can just delete the modal folder, as it was not supposed to be generated when you did not select bootstrap. |
@kingcody Were you able to reproduce the issue? When I say no to bootstrap, I don't get the modal service, or any of the related styles |
I was. I started with a completely new dir and mirrored @werm's choices. The modal folder was generated with the appropriate files according to the selected prompts, other than it should not have been generated. I used |
Changes: - `filters.bootstrap` and `filters.uibootstrap` will be true or false only Closes angular-fullstack#496
If you run the generator and choose Sass and no Bootstrap, the modal component's
scss
has Bootstrap variables in it ($brand-primary
,$brand-info
, etc.)I'd submit a pull request, but I'm not too familiar with the inner workings of Yeoman.
Steps taken...
The text was updated successfully, but these errors were encountered: