Skip to content

Build is injecting app script files and usemin is not replacing image names in templates. #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fusionstrings opened this issue Jul 19, 2014 · 20 comments
Labels

Comments

@fusionstrings
Copy link

While running successful build, controller and other components scripts are injected into index.html.

Also it's is not replacing optimized image names with renamed files in templates or CSS.

@DaftMonk
Copy link
Member

Could you elaborate on your setup? I couldn't reproduce this using the default options on the generator.

@fusionstrings
Copy link
Author

Well I am using version 2.0.4 and default setup as well. I am generating all components using command e.g. angular-fullstack:route specified in readme. When I am running grunt build I find index.html in dist folder have following block, which I believe should not be there as files are already minified and combined. Obviously this injection results in 404.
image

Also img tag's src property should be updated with renamed (usemin) image file but it's not happening.
image

@DaftMonk
Copy link
Member

Hmm, usemin should remove everything in those build:js blocks and replace it with the revved app.js that you have there. It should also take care of renaming those images. It does both those things for me.

Could you paste your full index.html, as well as the usemin output during the grunt build task?

@fusionstrings
Copy link
Author

Following is console output for usemin.
While reading this log I realized that probably usemin should also change reference of image in JS as well. It's not happening as well. I am using certain relative image URLs from images folder in angular model.

Just to add here if it helps I'd change gruntfile at line no. 220 to include nested folders in fonts folder from '<%= yeoman.dist %>/public/assets/fonts/*' to '<%= yeoman.dist %>/public/assets/fonts/{,*/}*.*' . That's only deviation I took from default configuration and guide.

Running "usemin:html" (usemin) task

Processing as HTML - dist/public/index.html
Update the HTML to reference our concat/min/revved script files
<script src="app/vendor.js" changed to <script src="app/89968304.vendor.js"
<script src="app/app.js" changed to <script src="app/2837bf8f.app.js"
Update the HTML with the new css filenames
<link rel="stylesheet" href="app/vendor.css" changed to <link rel="stylesheet" href="app/5afdf152.vendor.css"
<link rel="stylesheet" href="app/app.css" changed to <link rel="stylesheet" href="app/2bb2020f.app.css"
Update the HTML with the new img filenames
Update the HTML with data-main tags
Update the HTML with data-* tags
Update the HTML with background imgs, case there is some inline style
Update the HTML with anchors images
Update the HTML with reference in input

Running "usemin:css" (usemin) task

Processing as CSS - dist/public/app/2bb2020f.app.css
Update the CSS to reference our revved images
url(/assets/fonts/sprint/akzidgroprobolcndwebfont-webfont.eot) changed to url(/assets/fonts/sprint/f67a01d2.akzidgroprobolcndwebfont-webfont.eot)
url(/assets/fonts/sprint/akzidgroprobolcndwebfont-webfont.eot changed to url(/assets/fonts/sprint/f67a01d2.akzidgroprobolcndwebfont-webfont.eot
url(/assets/fonts/sprint/akzidgroprobolcndwebfont-webfont.woff) changed to url(/assets/fonts/sprint/041a3d32.akzidgroprobolcndwebfont-webfont.woff)
url(/assets/fonts/sprint/akzidgroprobolcndwebfont-webfont.ttf) changed to url(/assets/fonts/sprint/ba446fef.akzidgroprobolcndwebfont-webfont.ttf)
url(/assets/fonts/sprint/akzidgroprobolcndwebfont-webfont.svg changed to url(/assets/fonts/sprint/a4fd31d9.akzidgroprobolcndwebfont-webfont.svg
url(/assets/fonts/sprint/akzidgroproregwebfont-webfont.eot) changed to url(/assets/fonts/sprint/cdeec097.akzidgroproregwebfont-webfont.eot)
url(/assets/fonts/sprint/akzidgroproregwebfont-webfont.eot changed to url(/assets/fonts/sprint/cdeec097.akzidgroproregwebfont-webfont.eot
url(/assets/fonts/sprint/akzidgroproregwebfont-webfont.woff) changed to url(/assets/fonts/sprint/2f3f5ea9.akzidgroproregwebfont-webfont.woff)
url(/assets/fonts/sprint/akzidgroproregwebfont-webfont.ttf) changed to url(/assets/fonts/sprint/9a3a7db4.akzidgroproregwebfont-webfont.ttf)
url(/assets/fonts/sprint/akzidgroproregwebfont-webfont.svg changed to url(/assets/fonts/sprint/d2739708.akzidgroproregwebfont-webfont.svg
url("/assets/fonts/sprint/Sprint Sans Web-Black.eot") changed to url("/assets/fonts/sprint/b1fe07c6.Sprint Sans Web-Black.eot")
url("/assets/fonts/sprint/Sprint Sans Web-Black.eot changed to url("/assets/fonts/sprint/b1fe07c6.Sprint Sans Web-Black.eot
url("/assets/fonts/sprint/Sprint Sans Web-Black.woff") changed to url("/assets/fonts/sprint/b86c9a46.Sprint Sans Web-Black.woff")
url("/assets/fonts/sprint/Sprint Sans Web-Black.ttf") changed to url("/assets/fonts/sprint/b6b57e70.Sprint Sans Web-Black.ttf")
url("/assets/fonts/sprint/Sprint Sans Web-Black.svg changed to url("/assets/fonts/sprint/cb1785f7.Sprint Sans Web-Black.svg
url("/assets/fonts/sprint/Sprint Sans Web-Black Italic.eot") changed to url("/assets/fonts/sprint/d2255bde.Sprint Sans Web-Black Italic.eot")
url("/assets/fonts/sprint/Sprint Sans Web-Black Italic.eot changed to url("/assets/fonts/sprint/d2255bde.Sprint Sans Web-Black Italic.eot
url("/assets/fonts/sprint/Sprint Sans Web-Black Italic.woff") changed to url("/assets/fonts/sprint/b42b17ea.Sprint Sans Web-Black Italic.woff")
url("/assets/fonts/sprint/Sprint Sans Web-Black Italic.ttf") changed to url("/assets/fonts/sprint/637446f2.Sprint Sans Web-Black Italic.ttf")
url("/assets/fonts/sprint/Sprint Sans Web-Black Italic.svg changed to url("/assets/fonts/sprint/19cfafb1.Sprint Sans Web-Black Italic.svg
url("/assets/fonts/sprint/Sprint Sans Web-Bold.eot") changed to url("/assets/fonts/sprint/81969dba.Sprint Sans Web-Bold.eot")
url("/assets/fonts/sprint/Sprint Sans Web-Bold.eot changed to url("/assets/fonts/sprint/81969dba.Sprint Sans Web-Bold.eot
url("/assets/fonts/sprint/Sprint Sans Web-Bold.woff") changed to url("/assets/fonts/sprint/dc5c03c4.Sprint Sans Web-Bold.woff")
url("/assets/fonts/sprint/Sprint Sans Web-Bold.ttf") changed to url("/assets/fonts/sprint/117329d8.Sprint Sans Web-Bold.ttf")
url("/assets/fonts/sprint/Sprint Sans Web-Bold.svg changed to url("/assets/fonts/sprint/3f2172d4.Sprint Sans Web-Bold.svg
url("/assets/fonts/sprint/Sprint Sans Web-Bold Italic.eot") changed to url("/assets/fonts/sprint/b42e1cbe.Sprint Sans Web-Bold Italic.eot")
url("/assets/fonts/sprint/Sprint Sans Web-Bold Italic.eot changed to url("/assets/fonts/sprint/b42e1cbe.Sprint Sans Web-Bold Italic.eot
url("/assets/fonts/sprint/Sprint Sans Web-Bold Italic.woff") changed to url("/assets/fonts/sprint/d276988e.Sprint Sans Web-Bold Italic.woff")
url("/assets/fonts/sprint/Sprint Sans Web-Bold Italic.ttf") changed to url("/assets/fonts/sprint/5ef232c8.Sprint Sans Web-Bold Italic.ttf")
url("/assets/fonts/sprint/Sprint Sans Web-Bold Italic.svg changed to url("/assets/fonts/sprint/cd9d9e4b.Sprint Sans Web-Bold Italic.svg
url("/assets/fonts/sprint/Sprint Sans Web-Medium.eot") changed to url("/assets/fonts/sprint/4469148d.Sprint Sans Web-Medium.eot")
url("/assets/fonts/sprint/Sprint Sans Web-Medium.eot changed to url("/assets/fonts/sprint/4469148d.Sprint Sans Web-Medium.eot
url("/assets/fonts/sprint/Sprint Sans Web-Medium.woff") changed to url("/assets/fonts/sprint/702bb5b4.Sprint Sans Web-Medium.woff")
url("/assets/fonts/sprint/Sprint Sans Web-Medium.ttf") changed to url("/assets/fonts/sprint/b422f06b.Sprint Sans Web-Medium.ttf")
url("/assets/fonts/sprint/Sprint Sans Web-Medium.svg changed to url("/assets/fonts/sprint/1736944b.Sprint Sans Web-Medium.svg
url("/assets/fonts/sprint/Sprint Sans Web-Medium Italic.eot") changed to url("/assets/fonts/sprint/47e20ca2.Sprint Sans Web-Medium Italic.eot")
url("/assets/fonts/sprint/Sprint Sans Web-Medium Italic.eot changed to url("/assets/fonts/sprint/47e20ca2.Sprint Sans Web-Medium Italic.eot
url("/assets/fonts/sprint/Sprint Sans Web-Medium Italic.woff") changed to url("/assets/fonts/sprint/421e8da0.Sprint Sans Web-Medium Italic.woff")
url("/assets/fonts/sprint/Sprint Sans Web-Medium Italic.ttf") changed to url("/assets/fonts/sprint/9de0fc8e.Sprint Sans Web-Medium Italic.ttf")
url("/assets/fonts/sprint/Sprint Sans Web-Medium Italic.svg changed to url("/assets/fonts/sprint/2fc994d9.Sprint Sans Web-Medium Italic.svg
url("/assets/fonts/sprint/Sprint Sans Web-Regular.eot") changed to url("/assets/fonts/sprint/61e84efc.Sprint Sans Web-Regular.eot")
url("/assets/fonts/sprint/Sprint Sans Web-Regular.eot changed to url("/assets/fonts/sprint/61e84efc.Sprint Sans Web-Regular.eot
url("/assets/fonts/sprint/Sprint Sans Web-Regular.woff") changed to url("/assets/fonts/sprint/63fecc57.Sprint Sans Web-Regular.woff")
url("/assets/fonts/sprint/Sprint Sans Web-Regular.ttf") changed to url("/assets/fonts/sprint/e90e5fbe.Sprint Sans Web-Regular.ttf")
url("/assets/fonts/sprint/Sprint Sans Web-Regular.svg changed to url("/assets/fonts/sprint/c492d42f.Sprint Sans Web-Regular.svg
url("/assets/fonts/sprint/Sprint Sans Web-Regular Italic.eot") changed to url("/assets/fonts/sprint/70aa3cbe.Sprint Sans Web-Regular Italic.eot")
url("/assets/fonts/sprint/Sprint Sans Web-Regular Italic.eot changed to url("/assets/fonts/sprint/70aa3cbe.Sprint Sans Web-Regular Italic.eot
url("/assets/fonts/sprint/Sprint Sans Web-Regular Italic.woff") changed to url("/assets/fonts/sprint/ddb28af6.Sprint Sans Web-Regular
Italic.woff")
url("/assets/fonts/sprint/Sprint Sans Web-Regular Italic.ttf") changed to url("/assets/fonts/sprint/6dddf8cf.Sprint Sans Web-Regular Italic.ttf")
url("/assets/fonts/sprint/Sprint Sans Web-Regular Italic.svg changed to url("/assets/fonts/sprint/15e71cfc.Sprint Sans Web-Regular Italic.svg

Processing as CSS - dist/public/app/5afdf152.vendor.css
Update the CSS to reference our revved images

Running "usemin:js" (usemin) task

Processing as JS - dist/public/app/2837bf8f.app.js
Update the JS to reference our revved images

Processing as JS - dist/public/app/89968304.vendor.js
Update the JS to reference our revved images

Done, without errors.

This is content of index.html (from client folder and not from dist folder, dist folder index.html is after this).

<!doctype html>
<!--[if lt IE 7]>      <html class="no-js lt-ie9 lt-ie8 lt-ie7"> <![endif]-->
<!--[if IE 7]>         <html class="no-js lt-ie9 lt-ie8"> <![endif]-->
<!--[if IE 8]>         <html class="no-js lt-ie9"> <![endif]-->
<!--[if gt IE 8]><!--> <html class="no-js"> <!--<![endif]-->
  <head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <base href="/">
    <title></title>
    <meta name="description" content="">
    <meta name="viewport" content="width=device-width">
    <!-- Place favicon.ico and apple-touch-icon.png in the root directory -->
    <!-- build:css(client) app/vendor.css -->
      <!-- bower:css -->
      <link rel="stylesheet" href="bower_components/angular-carousel/dist/angular-carousel.css" />
      <!-- endbower -->
    <!-- endbuild -->
    <!-- build:css({.tmp,client}) app/app.css -->
    <link rel="stylesheet" href="app/app.css">
      <!-- injector:css -->
      <!-- endinjector -->
    <!-- endbuild -->
  </head>
  <body ng-app="sprintApp">
    <!--[if lt IE 7]>
      <p class="browsehappy">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>
    <![endif]-->

    <!-- Add your site or application content here -->
    <header>
      <div ng-include="'components/navbar/navbar.html'"></div>
    </header>

    <main class="view-slide-in" ui-view=""></main>

    <footer class="footer">
        <div class="container">
            <p>
              <a href="//www.sprint.com">Sprint</a> | &copy; 2014
            </p>
        </div>
    </footer>

    <!-- Google Analytics: change UA-XXXXX-X to be your site's ID -->
     <script>
       (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
       (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
       m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
       })(window,document,'script','//www.google-analytics.com/analytics.js','ga');

       ga('create', 'UA-XXXXX-X');
       ga('send', 'pageview');
    </script>

    <!--[if lt IE 9]>
    <script src="bower_components/es5-shim/es5-shim.js"></script>
    <script src="bower_components/json3/lib/json3.min.js"></script>
    <![endif]-->

    <!-- build:js(client) app/vendor.js -->
      <!-- bower:js -->
      <script src="bower_components/jquery/dist/jquery.js"></script>
      <script src="bower_components/angular/angular.js"></script>
      <script src="bower_components/json3/lib/json3.js"></script>
      <script src="bower_components/angular-resource/angular-resource.js"></script>
      <script src="bower_components/angular-cookies/angular-cookies.js"></script>
      <script src="bower_components/angular-sanitize/angular-sanitize.js"></script>
      <script src="bower_components/angular-bootstrap/ui-bootstrap-tpls.js"></script>
      <script src="bower_components/lodash/dist/lodash.compat.js"></script>
      <script src="bower_components/angular-ui-router/release/angular-ui-router.js"></script>
      <script src="bower_components/angular-animate/angular-animate.js"></script>
      <script src="bower_components/angular-touch/angular-touch.js"></script>
      <script src="bower_components/angular-carousel/dist/angular-carousel.js"></script>
      <!-- endbower -->
    <!-- endbuild -->

        <!-- build:js({.tmp,client}) app/app.js -->
        <script src="app/app.js"></script>
          <!-- injector:js -->
          <script src="app/community/community.controller.js"></script>
          <script src="app/community/community.js"></script>
          <script src="app/coverage/coverage.controller.js"></script>
          <script src="app/coverage/coverage.js"></script>
          <script src="app/discover/discover.controller.js"></script>
          <script src="app/discover/discover.js"></script>
          <script src="app/featured-apps/featured-apps.controller.js"></script>
          <script src="app/featured-apps/featured-apps.js"></script>
          <script src="app/main/main.controller.js"></script>
          <script src="app/main/main.js"></script>
          <script src="app/my-sprint/my-sprint.controller.js"></script>
          <script src="app/my-sprint/my-sprint.js"></script>
          <script src="app/shop/shop.controller.js"></script>
          <script src="app/shop/shop.js"></script>
          <script src="app/stores/stores.controller.js"></script>
          <script src="app/stores/stores.js"></script>
          <script src="app/support/support.controller.js"></script>
          <script src="app/support/support.js"></script>
          <script src="components/navbar/navbar.controller.js"></script>
          <!-- endinjector -->
        <!-- endbuild -->
</body>
</html>

And this is from index.html from dist\public folder.

<!doctype html>
<!--[if lt IE 7]>      <html class="no-js lt-ie9 lt-ie8 lt-ie7"> <![endif]-->
<!--[if IE 7]>         <html class="no-js lt-ie9 lt-ie8"> <![endif]-->
<!--[if IE 8]>         <html class="no-js lt-ie9"> <![endif]-->
<!--[if gt IE 8]><!--> <html class="no-js"> <!--<![endif]-->
  <head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <base href="/">
    <title></title>
    <meta name="description" content="">
    <meta name="viewport" content="width=device-width">
    <!-- Place favicon.ico and apple-touch-icon.png in the root directory -->
    <link rel="stylesheet" href="app/5afdf152.vendor.css"/>
    <link rel="stylesheet" href="app/2bb2020f.app.css"/>
  </head>
  <body ng-app="sprintApp">
    <!--[if lt IE 7]>
      <p class="browsehappy">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>
    <![endif]-->

    <!-- Add your site or application content here -->
    <header>
      <div ng-include="'components/navbar/navbar.html'"></div>
    </header>

    <main class="view-slide-in" ui-view=""></main>

    <footer class="footer">
        <div class="container">
            <p>
              <a href="//www.sprint.com">Sprint</a> | &copy; 2014
            </p>
        </div>
    </footer>

    <!-- Google Analytics: change UA-XXXXX-X to be your site's ID -->
     <script>
       (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
       (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
       m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
       })(window,document,'script','//www.google-analytics.com/analytics.js','ga');

       ga('create', 'UA-XXXXX-X');
       ga('send', 'pageview');
    </script>

    <!--[if lt IE 9]>
    <script src="bower_components/es5-shim/es5-shim.js"></script>
    <script src="bower_components/json3/lib/json3.min.js"></script>
    <![endif]-->

    <script src="app/89968304.vendor.js"></script>

        <!-- build:js({.tmp,client}) app/app.js -->
        <script src="app/2837bf8f.app.js"></script>
          <!-- injector:js -->
          <script src="app/community/community.controller.js"></script>
          <script src="app/community/community.js"></script>
          <script src="app/coverage/coverage.controller.js"></script>
          <script src="app/coverage/coverage.js"></script>
          <script src="app/discover/discover.controller.js"></script>
          <script src="app/discover/discover.js"></script>
          <script src="app/featured-apps/featured-apps.controller.js"></script>
          <script src="app/featured-apps/featured-apps.js"></script>
          <script src="app/main/main.controller.js"></script>
          <script src="app/main/main.js"></script>
          <script src="app/my-sprint/my-sprint.controller.js"></script>
          <script src="app/my-sprint/my-sprint.js"></script>
          <script src="app/shop/shop.controller.js"></script>
          <script src="app/shop/shop.js"></script>
          <script src="app/stores/stores.controller.js"></script>
          <script src="app/stores/stores.js"></script>
          <script src="app/support/support.controller.js"></script>
          <script src="app/support/support.js"></script>
          <script src="components/navbar/navbar.controller.js"></script>
          <!-- endinjector -->
        <!-- endbuild -->
</body>
</html>

@DaftMonk
Copy link
Member

Does this happen in a freshly scaffolded project?

@fusionstrings
Copy link
Author

Yes and it was scaffolded on 14th July, 2014

@DaftMonk
Copy link
Member

I mean if you don't change any files at all before running grunt serve:dist or grunt build

@fusionstrings
Copy link
Author

It appears fine on newly scaffold project. No duplicates. so I wonder what might be wrong but it boils down it's not but from generators side. So I am closing this bug and sorry for inconvenience caused.

@vinesh245
Copy link

I am having same issue with styles and scripts both.
@DaftMonk
@fusionstrings Can you please explain what was wrong?
and How did you solved it?

my client/index.html

<!-- build:css({.tmp,client}) app/app.css -->
<link rel="stylesheet" href="app/app.css">
  <!-- injector:css -->
  <link rel="stylesheet" href="app/account/login/login.css">
  <link rel="stylesheet" href="app/admin/admin.css">
  <link rel="stylesheet" href="app/main/main.css">
  <link rel="stylesheet" href="app/quiz/create/quiz.css">
  <link rel="stylesheet" href="components/modal/modal.css">
  <!-- endinjector -->
<!-- endbuild -->

    <!-- build:js({.tmp,client}) app/app.js -->
    <script src="app/app.js"></script>
      <!-- injector:js -->
      <script src="app/account/account.js"></script>
      <script src="app/account/login/login.controller.js"></script>
      <script src="app/account/settings/settings.controller.js"></script>
      <script src="app/account/signup/signup.controller.js"></script>
      <script src="app/account/signup/signup.ta.controller.js"></script>
      <script src="app/admin/admin.controller.js"></script>
      <script src="app/admin/admin.js"></script>
      <script src="app/main/main.controller.js"></script>
      <script src="app/main/main.js"></script>
      <script src="app/quiz/create/create.quiz.controller.js"></script>
      <script src="app/quiz/create/select.quiz.controller.js"></script>
      <script src="app/quiz/display/quiz.list.controller.js"></script>
      <script src="app/quiz/quiz.directive.js"></script>
      <script src="app/quiz/quiz.filters.js"></script>
      <script src="app/quiz/quiz.js"></script>
      <script src="app/quiz/quiz.services.js"></script>
      <script src="components/auth/auth.service.js"></script>
      <script src="components/auth/user.service.js"></script>
      <script src="components/modal/modal.service.js"></script>
      <script src="components/mongoose-error/mongoose-error.directive.js"></script>
      <script src="components/navbar/navbar.controller.js"></script>
      <!-- endinjector -->
    <!-- endbuild -->

generated dist/public/index.html contains:

<!-- build:css({.tmp,client}) app/app.css -->
<link rel="stylesheet" href="app/c90b5a84.app.css">
  <!-- injector:css -->
  <link rel="stylesheet" href="app/account/login/login.css">
  <link rel="stylesheet" href="app/admin/admin.css">
  <link rel="stylesheet" href="app/main/main.css">
  <link rel="stylesheet" href="app/quiz/create/quiz.css">
  <link rel="stylesheet" href="components/modal/modal.css">
  <!-- endinjector -->
<!-- endbuild -->

    <!-- build:js({.tmp,client}) app/app.js -->
    <script src="app/5610549b.app.js"></script>
      <!-- injector:js -->
      <script src="app/account/account.js"></script>
      <script src="app/account/login/login.controller.js"></script>
      <script src="app/account/settings/settings.controller.js"></script>
      <script src="app/account/signup/signup.controller.js"></script>
      <script src="app/account/signup/signup.ta.controller.js"></script>
      <script src="app/admin/admin.controller.js"></script>
      <script src="app/admin/admin.js"></script>
      <script src="app/main/main.controller.js"></script>
      <script src="app/main/main.js"></script>
      <script src="app/quiz/create/create.quiz.controller.js"></script>
      <script src="app/quiz/create/select.quiz.controller.js"></script>
      <script src="app/quiz/display/quiz.list.controller.js"></script>
      <script src="app/quiz/quiz.directive.js"></script>
      <script src="app/quiz/quiz.filters.js"></script>
      <script src="app/quiz/quiz.js"></script>
      <script src="app/quiz/quiz.services.js"></script>
      <script src="components/auth/auth.service.js"></script>
      <script src="components/auth/user.service.js"></script>
      <script src="components/modal/modal.service.js"></script>
      <script src="components/mongoose-error/mongoose-error.directive.js"></script>
      <script src="components/navbar/navbar.controller.js"></script>
      <!-- endinjector -->
    <!-- endbuild -->

If I remove <-- endinjector --> and <-- endinjector --> from client/index.html then its working as expected.

@stieler-it
Copy link

@vinesh245 Did you find out why the scripts are not removed? I currently experience the same problem..

@stieler-it
Copy link

Ok, maybe this is useful for anyone else: Make sure that your source HTML (e.g. index.html) does not mix linefeed styles (unix/windows). Usemin assumes that the lines are separated equally - otherwise block replacement will probably fail. I read that the usemin team plans to migrate from regular expressions to a html parser which would probably solve this issue.

@raghavbali
Copy link

👍 Awesome @stieler-it ! That really did the trick

@talesporto
Copy link

👍 Awesome @stieler-it! Thanks about it!!! I work hard here!!!

@SaintPeter
Copy link
Contributor

+1 @stieler-it Thank you sir!

@shairez
Copy link

shairez commented Aug 18, 2015

Thanks @stieler-it !

BTW, the configuration in the grunt injector task options is -
options: {
lineEnding: '\r'
}

@luxueyan
Copy link

@shairez Thanks!This help me !

@solon-user
Copy link

I had the same problem but with .css files using a Windows machine. Fixed by changing line endings to 'unix' from 'Windows' in Sublime Text 2.

@Shingaz
Copy link

Shingaz commented Jan 26, 2016

I had this issue a year ago, I fixed it adding the following option to injector Grunt task:

injector: {
   options: {
      lineEnding: grunt.util.linefeed
   }
}

@pspriyankasethi
Copy link

@stieler-it: You are a genius!

@pspriyankasethi
Copy link

@Awk34 : Thank you, your issue linking helped! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests