-
Notifications
You must be signed in to change notification settings - Fork 1.2k
refactor(gen:endpoint): configurable route url #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mvhenderson I keep thinking this is a PR. Would you mind making one instead? |
Sure, will have a PR in a few days. |
* Configurable route base, defaults to `/api/`. This only affects the client URL, the backend code will still be written to `server/api`. * Configurable pluralization of route, defaults to true. Closes angular-fullstack#338
@JaKXz Can you help me figure out why the Travis CI test is failing? I suspect this might be an async race condition. In the Travis log, I see this:
However, when I do a default install followed by a
Notice the Here are the steps I used to try to replicate the Travis error:
|
Got the same error few hours ago, I think it's due to some timeout on the server, so little random, get a build error and a passed with the exact same commit. I manage to resolve the problem by increasing the timeout of the |
@apercu I don't think changing the mocha timeout actually fixed it, just by chance it worked. Looks like the db operations in |
@mvhenderson nice catch. I was wondering why my purely client side code style fixes raised db errors :). Would love to hear once it gets resolved. When I |
What @mvhenderson said. Thanks guys. |
Make the server endpoint base url configurable similar the client directories.
Also remove plurization, make it optional or pluralize correctly (i.e. glass to glasses not glasss) perhaps using underscore.inflection.
If plurization is removed, it should be a one-liner, from:
to
The text was updated successfully, but these errors were encountered: