Skip to content

Enhancement: Remove problematic shrink-ray module from default package #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MariusStuparu opened this issue Sep 28, 2017 · 0 comments · Fixed by #2641
Closed

Enhancement: Remove problematic shrink-ray module from default package #2639

MariusStuparu opened this issue Sep 28, 2017 · 0 comments · Fixed by #2641

Comments

@MariusStuparu
Copy link

MariusStuparu commented Sep 28, 2017

As some others have said in other issues, shrink-ray module has a nasty dependency in the iltorb module. iltorb needs binary compilation with node-pre-gyp and node-gyp, and this has failed for me on all OSs that I've tried: on OSX 10.12 and 10.13 it fails 50% of the time, on Windows 8 and 10 it requires a lot of other instalations, and still fails 50% of the time, and on CentOS 6 (my production server) it just does not install, so 100% fail. It only worked on the Ubuntu machine that Heroku deploys. I had to remove it from package.json and from Express to make the app run.

I know it's an external module, and may be useful, but, in production, you would already have some other layers above the app that can compress the data, like an Apache and/or NGINX proxy, that already have functional compression modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant