[email protected] will miss file when building, while [email protected] OK

[jacinchan]

Item	Version
generator-angular-fullstack	3.7.6
Node	5.10.1
npm	x.x.x
Operating System	OS X 10 / Windows 10 / Ubuntu 15.10 / etc
etc	etc

Item	Answer
Transpiler	Babel
Markup	HTML
CSS	SCSS
Router	ui-router
Client Tests	Mocha
DB	MongoDB
Auth	N
etc	etc

when I use gulp build, i found app.js did not uglity or rev
problem is
[email protected] will miss some files.
if i reset to [email protected], it's OK
see the gulp file here

in gulp.task('build:client')

return gulp.src(paths.client.mainView)
.pipe(plugins.useref())
.pipe(appFilter)
.pipe(plugins.addSrc.append('.tmp/templates.js'))
.pipe(plugins.concat('app/app.js'))
.pipe(appFilter.restore) ------------- // app/app.js is included
.pipe(jsFilter) ------------- // app/app.js is excluded!
.pipe(plugins.ngAnnotate())
.pipe(plugins.uglify())
.pipe(jsFilter.restore)
.pipe(cssFilter)
.pipe(plugins.cleanCss({
processImportFrom: ['!fonts.googleapis.com']
}))
.pipe(cssFilter.restore)
.pipe(htmlBlock) //the same problem here
.pipe(plugins.rev())
.pipe(htmlBlock.restore)
.pipe(plugins.revReplace({manifest}))
.pipe(gulp.dest(${paths.dist}/${clientPath}));

[Awk34]

Could you elaborate more? Why would gulp-filter 4 break this while it works with 3?

[jacinchan]

[email protected] change the way of calling multimatch
4.0.0 -- > multimatch(path.relative(file.cwd, file.path), pattern, options)
test

console.log(minimatch(".tmp/app/app.js", "**/*.js")); //false
console.log(minimatch(".tmp/app/app.js", "**/*.js",{dot:true})); //true

that the problem.
so if we use [email protected]
our filter option must add {dot:true}
that's

var appFilter = plugins.filter('**/app.js', {restore: true, dot:true});
var jsFilter = plugins.filter('**/*.js', {restore: true, dot:true});
var cssFilter = plugins.filter('**/*.css', {restore: true, dot:true});
var htmlBlock = plugins.filter(['**/*.!(html)'], {restore: true, dot:true});

[Awk34]

Would you be comfortable sending a pull request to the 3.x.x branch?

[jacinchan]

well, it's my first pull request... i don't know how to use actually.