Skip to content

Heroku deployment and git repo #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmirGilboa opened this issue Jun 3, 2016 · 9 comments
Open

Heroku deployment and git repo #1950

AmirGilboa opened this issue Jun 3, 2016 · 9 comments
Labels

Comments

@AmirGilboa
Copy link

Apologies for another newbie question.
I want to deploy to heroku, and i read that it's all based on git repo.
Just as you have your github or bitbucket "remote" (central storage), you define a new one that is heroku. and you are basically pushing your code, instead of to your regular remote, to the newly created heroku remote.
That is all good, but i don't really want all my code to travel to the production server.
I only want the 'dist' folder, the complied, transpiled, minified, etc, to be copied to the server.
How to achieve that?
Do i have to manage another git repo just for deployment?
How do i make sure the 2 repos will not mix and confuse each other?

@Awk34
Copy link
Member

Awk34 commented Jun 3, 2016

IIRC the code that gets pushed to Heroku is only the prod code. Check with the repo that's created in /dist

@Awk34 Awk34 added the Heroku label Jun 3, 2016
@AmirGilboa
Copy link
Author

great.
the command
yo angular-fullstack:heroku
should be run at the root, or in the dist folder?
what is the expected outcome? it only asks me for a name, and then returns without any noticeable change.

and please allow me to ask again, this is critical: are we dealing with 2 different repositories here?
one for our day to day source control, and one for heroku deployment? or is it one?

thanks.

@Awk34
Copy link
Member

Awk34 commented Jun 3, 2016

It should be run from the root. ls -lah dist to be sure it worked.

I don't use Heroku, but if my memory serves me correctly yes, there's a different git repo created for the code that goes to heroku

@AmirGilboa
Copy link
Author

Thanks.
Nothing actually happens when i run this command in the root.
it is asking for a name to deploy as (leave blank for random name), and returns as if nothing happened. no git repo created or any other change.
maybe i should manually create the repo, and the generator will only check in to it?
Where is the code that is being activated? should be in the gruntfile, right?

@Awk34
Copy link
Member

Awk34 commented Jun 4, 2016

@djpark
Copy link

djpark commented Jun 9, 2016

If you want to deploy to heroku, 1) build your project then 2) run the buildcontrol command from your /dist folder:

grunt buildcontrol:heroku

Make sure that your git remote is set appropriately in your /dist folder. You can check with git remote -v

@bestconsultant
Copy link

@djpark Before that you need to run yo angular-fullstack:heroku and that's where it's not working. I'm getting the following (and not useful) message : (!) NamedBase constructor is deprecated. See yeoman/generator#882

@bestconsultant
Copy link

@Awk34 It doesn't work either when you give it a name.

@bestconsultant
Copy link

My solution #1966

aniknafs added a commit to aniknafs/generator-angular-fullstack that referenced this issue Oct 18, 2016
Remove 'yo angular-fullstack:heroku' (not working)
Update docs to reflect manual setup

Fixes: angular-fullstack#1966, angular-fullstack#1950
aniknafs added a commit to aniknafs/generator-angular-fullstack that referenced this issue Oct 18, 2016
Remove 'yo angular-fullstack:heroku' (not working)
Update docs to reflect manual setup

Fixes: angular-fullstack#1966, angular-fullstack#1950
aniknafs added a commit to aniknafs/generator-angular-fullstack that referenced this issue Oct 18, 2016
Remove 'yo angular-fullstack:heroku' (not working)
Update docs to reflect manual setup

Fixes: angular-fullstack#1966, angular-fullstack#1950
aniknafs added a commit to aniknafs/generator-angular-fullstack that referenced this issue Oct 19, 2016
Remove 'yo angular-fullstack:heroku' (not working)
Update docs to reflect manual setup

Fixes: angular-fullstack#1966, angular-fullstack#1950
aniknafs added a commit to aniknafs/generator-angular-fullstack that referenced this issue Oct 19, 2016
Remove 'yo angular-fullstack:heroku' (not working)
Update docs to reflect manual setup

Fixes: angular-fullstack#1966, angular-fullstack#1950
Awk34 pushed a commit that referenced this issue Oct 19, 2016
* docs (generators): Heroku generator run manually

Remove 'yo angular-fullstack:heroku' (not working)
Update docs to reflect manual setup

Fixes: #1966, #1950. [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants