Skip to content

Investigate why Thing API & Socket.io routes don't always get injected #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Awk34 opened this issue Jan 28, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@Awk34
Copy link
Member

Awk34 commented Jan 28, 2016

I've seen quite a few reports that routes.js and socketio.js aren't getting the require's for thing automatically injected from initial scaffold.

@Awk34 Awk34 added this to the Soon milestone Mar 10, 2016
@Awk34 Awk34 self-assigned this Mar 10, 2016
@Awk34
Copy link
Member Author

Awk34 commented Mar 10, 2016

I think I know why this happens. We have the code to add lines to routes.js, socketio.js, etc in the Yeoman end lifecycle stage, which is after the install lifecycle stage, and I think some people might be exiting during install (maybe because it hangs). We shouldn't do this work in end, but probably at the end of writing.

@Awk34 Awk34 closed this as completed in dc941ef Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant