Issue #2: Support for debugging TypeScript with JavaScript Debugger. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@angelozerr - it turns out that the code is needed only on TypeScript side - it should work with current Webclipse release.
I have adapted breakpoint support from JSDT editor. The adapter support creates normal JSDT breakpoints, so that it will work with any JSDT compatible debugger, which support source maps - so far it's only Webclispe one :)
I have added changes to existing Editor plugin and directly referenced some internal classes from JSDT Debug UI in plugin.xml. You might want to extract this code to separate debug code and duplicate internal JSDT action handling classes in it.
Anyway, please test this support ASAP, since we are going to release Webclispe this week and it would be cool to include any bugfixes if needed.