Skip to content

Improve method auto-completion writing parameter names #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
micaelgallego opened this issue Mar 12, 2016 · 7 comments
Closed

Improve method auto-completion writing parameter names #37

micaelgallego opened this issue Mar 12, 2016 · 7 comments
Milestone

Comments

@micaelgallego
Copy link

In JDT when you select a method from autocomplete list, parenthesis are written to code, and the parameter names (from documentation or source code) are written also. The parameters are also selected to edit them. Moreover, in methods with several parameters, every parameter is boxed and developer can navigate with tab key between them. I think TypeScript should have the same behavior. For now, only the method name is written to the file.

@angelozerr
Copy link
Owner

Indeed, I had this idea. I have already done that inside tern.java

@angelozerr
Copy link
Owner

angelozerr commented May 18, 2016

I have implemented this feature.

It works like JDT Recommenders: the completion items which are shown, matche prefix with "longest continuous sequence" (and not with starts with) like JDT does. If you have Neon, you will have highlight. Here a demo:

typescriptcompletiondemo

@micaelgallego @piotrtomiak do you think we must have a preference to choose completion wich works with "starts with"?

@micaelgallego
Copy link
Author

Awesome work ;)...

But I prefer to stay as close to JDT as possible to reduce the uncanny valley when working with Java and TypeScript in the same project.

@angelozerr
Copy link
Owner

But I prefer to stay as close to JDT

You mean that it is OK. If yes can I close this issue?

@micaelgallego
Copy link
Author

I think it would be good to have a preference to choose between this behavior and "starts with" behavior.

But it is up to you ;)

@angelozerr
Copy link
Owner

I think it would be good to have a preference to choose between this behavior and "starts with" behavior.

Ok but this behaviour is now with JDT Eclipse Neon

@micaelgallego
Copy link
Author

Ahhh... I didn't understand you sorry ;)

Then close the issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants