Computus Common Lisp Implementation #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
added
the
Implementation
leios
reviewed
Jul 7, 2020
contents/computus/computus.md
Outdated
| @@ -285,6 +285,18 @@ For now, we have the code outputting a tuple of $$d$$ and $$e$$, so users can us | |||
| [import, lang:"python"](code/python/gauss_easter.py) | |||
| {% sample lang="crystal" %} | |||
| [import, lang:"crystal"](code/crystal/gauss_easter.cr) | |||
| (defun computus (year &optional (servois nil)) | |||
There was a problem hiding this comment.
I think this was a copy and paste error.
berquist
approved these changes
Jul 11, 2020
| (e (mod (+ (* 2 b) (* 4 c) (* 6 d) n) 7))) | ||
| ;; historical corrections for April 26 and 25 | ||
| (when (or (and (eql d 29) (eql e 6)) (and (eql d 28) (eql e 6) (> a 10))) | ||
| (setf e -1)) |
There was a problem hiding this comment.
Is it possible to do the same thing as in the Rust implementation where you can use a conditional as an expression?
There was a problem hiding this comment.
It's a bit tricky to do that, because the value of e is necessary for the conditional. I could definitely do it, but I feel it wouldn't help much. The Rust implementation also has to calculate a temp_e to make it work out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very proud of this one. I took some time to clean it up right away and I'm happy with the result.