Skip to content

Euclidean algorithm in coconut #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 5, 2020
Merged

Euclidean algorithm in coconut #721

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9a5c102
Added Euclidean algorithm in Coconut
Amaras Jul 3, 2020
081b5a4
Added the language in the .md file
Amaras Jul 3, 2020
b3dbf4c
slight modification of the md file
Amaras Jul 4, 2020
fd9b90a
Addressed first part of @berquist review
Amaras Jul 5, 2020
1b93aec
Corrected the md file
Amaras Jul 5, 2020
71cfdb2
Final correction of the md file
Amaras Jul 5, 2020
534b557
Added Coconut in book.json
Amaras Jul 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions contents/euclidean_algorithm/code/cocount/euclidean.coco
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
def euclid_sub(a is int, 0) = a
addpattern def euclid_sub(0, b is int) = b

addpattern def euclid_sub(a is int, b is int):
if a == b:
return a
elif a < b:
return euclid_sub(a, b - a)
elif b < a:
return euclid_sub(a - b, b)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you order this like the Python implementation, where there's implicit fallthrough for the a == b case?



def euclid_mod(a is int, 0) = a
addpattern def euclid_mod(0, b is int) = b

addpattern def euclid_mod(a is int, b is int) = euclid_mod(b, a % b)

if __name__ == '__main__':
print('Euclidean mod:', euclid_mod(64 * 67, 64 * 81))
print('Euclidean sub:', euclid_sub(128 * 12, 128 * 77))
6 changes: 6 additions & 0 deletions contents/euclidean_algorithm/euclidean_algorithm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ The algorithm is a simple way to find the *greatest common divisor* (GCD) of two

{% sample lang="ps1" %}
[import:1-14, lang="powershell"](code/powershell/euclidean_algorithm.ps1)
{% sample lang="coco" %}
[import:1-11, lang="coconut"](code/coconut/euclidean.coco)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[import:1-11, lang="coconut"](code/coconut/euclidean.coco)
[import:1-10, lang="coconut"](code/coconut/euclidean.coco)

(assuming you don't do the case reordering)


{% endmethod %}

Expand Down Expand Up @@ -169,6 +171,8 @@ Modern implementations, though, often use the modulus operator (%) like so

{% sample lang="ps1" %}
[import:16-27, lang="powershell"](code/powershell/euclidean_algorithm.ps1)
{% sample lang="coco" %}
[import:13-21, lang="coconut"](code/coconut/euclidean.coco)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[import:13-21, lang="coconut"](code/coconut/euclidean.coco)
[import:13-16, lang="coconut"](code/coconut/euclidean.coco)


{% endmethod %}

Expand Down Expand Up @@ -282,6 +286,8 @@ The code snippets were taken from this [Scratch project](https://scratch.mit.edu

{% sample lang="ps1" %}
[import, lang="powershell"](code/powershell/euclidean_algorithm.ps1)
{% sample lang="coco" %}
[import, lang="coconut"](code/coconut/euclidean.coco)

{% endmethod %}

Expand Down