Huffman Encoding Scratch Implementation #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am impressed! Good work! We'll get to a review soon! |
|
I can do a review, I also implemented (dynamic) Huffman encoding with Scratch (unshared). Is there an actual Scratch project? It would be easier to play with. |
|
Yeah, I shared it (with extra interacting part which is a simple enter-text-and-say-result loop). The link is already in the chapter. Maybe drawing the tree out can be better, but I didn't implement it partially because I didn't have enough time. Anyway, that can be done independently without revisiting the chapter and code. |
|
TimothyJu1985 archived:false |
berquist
added
the
Implementation
|
I am unfortunately not a scratch master like @jiegillet, but can take a look at this, if needed. Let me know! |
|
Hi, is the review going on? |
leios
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally find a way to fix the buggy image... just set
transform: scale(1).