-
-
Notifications
You must be signed in to change notification settings - Fork 360
removing principles of code chapter, updating book #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing principles of code chapter, updating book #250
Conversation
For all the chapters that get moved and not deleted: we should maybe add redirects for them. |
yup, they should. I'll get the chapters consistent and then see about the redirects. |
The restructuring with the latest changes and the redirects looks good :) |
Nope, that was it, I think. It's good for a review, if you are up for it. |
|
I think we should always have the Title of each page in the biggest style i.e. |
SUMMARY.md
Outdated
* [Complexity Notation](chapters/general/notation/notation.md) | ||
* [Bit Logic](chapters/general/bitlogic/bitlogic.md) | ||
* [Convolutions](chapters/algorithms/convolutions/convolutions.md) | ||
* [Taylor Series](chapters/general/taylor_series/taylor_series.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file taylor_series.md
and the enclosing folder shouldn't exist, since there's already the taylor_series_expansion.md
with its enclosing folder.
If this file is an updated version of the taylor_series_expansion.md
however, you should delete the old one and rename the taylor_series.md
, so it doesn't violate the naming guidelines.
Ok, so I added a few questions and change requests. |
I think these latest commits fix those problems. |
Everything seems fine, I have no more complains. |
This PR addressed #33 . It removes the principle of code section (which was kinda aimless rambling anyway) and transforms it into mathematical background and data structures chapters, both of which will be continually updated with time.
It also moves other chapters to their relevant location.
As a note, this also hides work-in-progress sections from the site. In principle, these should all be hidden away in branches on my local fork, but I'll get to that soon. It also removed the personal note. It was basically a discussion about linux anyway, which is not relevant to algorithms.