Skip to content

removing principles of code chapter, updating book #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2018

Conversation

leios
Copy link
Member

@leios leios commented Jul 15, 2018

This PR addressed #33 . It removes the principle of code section (which was kinda aimless rambling anyway) and transforms it into mathematical background and data structures chapters, both of which will be continually updated with time.

It also moves other chapters to their relevant location.

As a note, this also hides work-in-progress sections from the site. In principle, these should all be hidden away in branches on my local fork, but I'll get to that soon. It also removed the personal note. It was basically a discussion about linux anyway, which is not relevant to algorithms.

@june128 june128 added General Chapter This provides a new chapter. (md files are edited) labels Jul 15, 2018
@june128
Copy link
Member

june128 commented Jul 16, 2018

For all the chapters that get moved and not deleted: we should maybe add redirects for them.

@leios
Copy link
Member Author

leios commented Jul 16, 2018

yup, they should. I'll get the chapters consistent and then see about the redirects.

@june128
Copy link
Member

june128 commented Jul 16, 2018

The restructuring with the latest changes and the redirects looks good :)
Do you plan to introduce more changes on this PR?

@leios
Copy link
Member Author

leios commented Jul 16, 2018

Nope, that was it, I think. It's good for a review, if you are up for it.

@leios leios requested a review from june128 July 16, 2018 20:10
@june128
Copy link
Member

june128 commented Jul 17, 2018

As a note, this also hides work-in-progress sections from the site. what do you mean by that? There are still chapters that just say "coming soon".

@june128
Copy link
Member

june128 commented Jul 17, 2018

I think we should always have the Title of each page in the biggest style i.e. #.
If you agree, how_to_contribute.md, version_control.md, notation.md and differential_equations.md, physics_solvers.md, backward_euler_method.md would need a change regarding the title.

SUMMARY.md Outdated
* [Complexity Notation](chapters/general/notation/notation.md)
* [Bit Logic](chapters/general/bitlogic/bitlogic.md)
* [Convolutions](chapters/algorithms/convolutions/convolutions.md)
* [Taylor Series](chapters/general/taylor_series/taylor_series.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file taylor_series.md and the enclosing folder shouldn't exist, since there's already the taylor_series_expansion.md with its enclosing folder.

If this file is an updated version of the taylor_series_expansion.md however, you should delete the old one and rename the taylor_series.md, so it doesn't violate the naming guidelines.

@june128
Copy link
Member

june128 commented Jul 17, 2018

Ok, so I added a few questions and change requests.

@leios
Copy link
Member Author

leios commented Jul 17, 2018

I think these latest commits fix those problems.

@june128
Copy link
Member

june128 commented Jul 17, 2018

Everything seems fine, I have no more complains.

@june128 june128 merged commit c052e21 into algorithm-archivists:master Jul 17, 2018
@leios leios deleted the update_in_principle branch July 17, 2018 20:25
@leios leios mentioned this pull request Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapter This provides a new chapter. (md files are edited) General
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants