Fix the size of the diagrams. Add res folders. #170
Conversation
…ize of the diagrams.
june128
added
the
Chapter Edit
|
Also: What do you (reviewer) think about the size of the images. |
…y Notation chapter.
…e images of Version Control in the same way as in other chapters.
|
Ok, a few question came up for me, while I'm working on this. First of all: should the image here be centered as well? I did it in a commit, but I can easily revert it. Also: I added a few to <p align="center">
<img src="path" />
</p>since the latter one is also used, when we need to specify a certain size and having all images included the same way seemed nice. |
| @@ -51,7 +51,9 @@ Now, solving this set of equations in this way is known as the *forward* Euler M | |||
| In fact, there is another method known as the [*backward* Euler Method](backward_euler.md), which we will get to soon enough. | |||
| For now, it is important to note that the error of these methods depend on the timestep chosen. | |||
|
|
|||
| <div style="text-align:center"><img src ="res/error.png" /></div> | |||
| <p align="center"> | |||
There was a problem hiding this comment.
You should not use the "align" attribute. We already have a custom CSS file to fix some syntax highlighting, you should add a class there.
There was a problem hiding this comment.
Can you do that? I'm not really familiar with CSS.
There was a problem hiding this comment.
Sure, I'll send you a PR soon™ (but seriously, it might take a few days, anyone else who wants to do it, feel free)
There was a problem hiding this comment.
I added something to the file, that seems to provide the desired result.
june128
changed the title
|
Hey @julianschacher, I think the centered (HTML) version is best, but I am also not sure what file to update about the custom CSS and stuff. If you guys think there is a better way for different screen resolutions, please let me know. Right now, I have been manually specifying the size of each image, which is not necessarily the best. |
…Taylor Series in the same way as in other chapters.
…as well. Therefore avoid distortion for images.
|
Using the |
…he same way as in other chapters.
styles/website.css
Outdated
| @@ -9,3 +9,9 @@ | |||
| .book .book-body .page-wrapper { | |||
| margin-bottom: 12em; | |||
| } | |||
|
|
|||
| img { | |||
There was a problem hiding this comment.
This is probably not what you want. This changes the style of every <img> element, including, for example, the CC banner at the bottom of the front page.
Also add res folder for building_blocks and move images into it.
This is targeting this card https://github.com/algorithm-archivists/algorithm-archive/projects/11#card-10967676