Skip to content

Commit 7dae55d

Browse files
committed
Reverted last change for map compilation where extension was omitted. Instead the file browser dialog was fixed because it was using the wrong .smt extension instead of .smf
1 parent 7056fe3 commit 7dae55d

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

MapCreationTool/MapCreationTool/Controls/CompilationSettingsControl.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<StackPanel Orientation="Vertical">
1616

1717
<compile:ValueCompileSetting SettingName="Output file" SettingDescription="The output smf file to create. E.g Zero-Prime.smf (REQUIRED)" DataContext="{Binding CompilationSettings}"
18-
SettingDialogType="Save" FileDialogFilter="smf files (*.smf)|*.smt|All files (*.*)|*.*"
18+
SettingDialogType="Save" FileDialogFilter="smf files (*.smf)|*.smf|All files (*.*)|*.*"
1919
SettingEnabledLocked="true" SettingIsEnabled="True"
2020
SettingValue="{Binding Path=OutSmfFilePath, Mode=TwoWay}"></compile:ValueCompileSetting>
2121
<compile:ValueCompileSetting SettingName="Include texture" SettingDescription="The diffuse map file to use. (REQUIRED)" DataContext="{Binding CompilationSettings}"

MapCreationTool/MapCreationTool/Controls/CompileMapControl.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ private void Compiler_CompilationResult(object sender, MapCompilerState state, M
7676
{
7777
CompilationResults += message + "\n";
7878
Dispatcher.Invoke(() => scrollViewer.ScrollToBottom());
79-
8079
}
8180

8281
private void CompileDeployControl_OnExecuteAction(object sender, ActionTypes actionType)

MapCreationTool/MapCreationTool/MapConverter/ProjectSettingsToCompilerSettingsConverter.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ public static PyMapCompilerSettings Convert(ProjectSettings projectSettings)
4242
PyMapCompilerSettings settings = new PyMapCompilerSettings();
4343
SettingsAdder adder = new SettingsAdder(settings);
4444

45-
// we don't want the outsmfFilepath to have any extension. Therefore we remove it. It will be automatically added by pymapconv again
46-
string outSmtPath = PathHelper.GetFilePathWithoutExtension(compSettings.OutSmfFilePath);
47-
48-
adder.AddSettingIfSet("-o", outSmtPath, true);
45+
adder.AddSettingIfSet("-o", compSettings.OutSmfFilePath, true);
4946
adder.AddSettingIfSet("-t", compSettings.DiffuseMapName, true);
5047
adder.AddSettingIfSet("-a", compSettings.HeightMapName, true);
5148
adder.AddSettingIfSet("-m", compSettings.MetalMapName, compSettings.UseMetalMap);

MapCreationTool/MapCreationTool/Models/ProjectSettings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace MapCreationTool.Models
1414
public class ProjectSettings : PropertyChangedBase
1515
{
1616
public const string DEFAULT_FILE_NAME = "MapCreationTool.xml";
17-
public const string GEO_VENT_FILE_NAME = "geovent.bmp";
17+
public const string GEO_VENT_FILE_NAME = @"PyMapConv\geovent.bmp";
1818

1919
private string startLocations;
2020
private MapPathInformation mapPathInformation;

0 commit comments

Comments
 (0)